[release-v0.45.x] CI: Use goinstall mode for golangci-lint action#2986
Open
vdemeester wants to merge 1 commit into
Open
[release-v0.45.x] CI: Use goinstall mode for golangci-lint action#2986vdemeester wants to merge 1 commit into
vdemeester wants to merge 1 commit into
Conversation
The prebuilt golangci-lint binary was built with Go 1.25, which is incompatible with our Go 1.26 toolchain. Switch to install-mode: goinstall so golangci-lint is compiled from source using the project's Go version, avoiding the mismatch. Cherry-pick of fix from main to release-v0.45.x. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Cherry-pick of #2984 to release-v0.45.x.
The prebuilt golangci-lint binary was built with Go 1.25, which is incompatible with our Go 1.26 toolchain. Switch to
install-mode: goinstallso golangci-lint is compiled from source using the project's Go version, avoiding the mismatch.Submitter Checklist
Release Notes