chore: standardize pnpm workflow setup - #2
Conversation
(cherry picked from commit d1d9d1d64451f45cf70c21f4a4626e8f9e436ac2)
(cherry picked from commit 34b4f3f5a958e106f60ed59c7bd43f5df3978dd9)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14ac9eb71e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a52681fada
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| export default defineConfig({ | ||
| base: "/", | ||
| base: "./", |
There was a problem hiding this comment.
For a plain pnpm build, Vite substitutes "./" for import.meta.env.BASE_URL, which src/index.tsx passes directly to BrowserRouter as its basename. Because browser pathnames start with / and do not match that relative basename, the built app renders no route at / or /about; the deploy workflow avoids this only because it overrides --base, while the newly documented default build and pnpm preview remain broken. Keep an absolute router basename or decouple it from the relative asset base.
AGENTS.md reference: AGENTS.md:L5-L8
Useful? React with 👍 / 👎.
Standardizes pnpm/Node setup with a repository-local composite action and explicit frozen installs, bumps @concertypin/config to 0.2, and makes pnpm check apply format/lint fixes.