Skip to content

Gate test-only worker telemetry helper - #1176

Merged
Sushisource merged 2 commits into
temporalio:masterfrom
edo-chan:ed/swi-320-adding-worker-service-scaffold
Mar 25, 2026
Merged

Sushisource merged 2 commits into
temporalio:masterfrom
edo-chan:ed/swi-320-adding-worker-service-scaffold

Conversation

@edo-chan

Copy link
Copy Markdown
Contributor

Summary

  • gate WorkerTelemetry::from_meter behind the same test-utilities / test cfg used by the helper paths that call it
  • remove the dead-code warning from normal builds without changing runtime behavior

Testing

  • cargo +nightly fmt
  • cargo lint
  • cargo test
  • cargo integ-test

@edo-chan
edo-chan requested a review from a team as a code owner March 24, 2026 02:37

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

Tip: disable this comment in your organization's Code Review settings.

@CLAassistant

CLAassistant commented Mar 24, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Sushisource Sushisource left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I kept meaning to get around to this.

@Sushisource
Sushisource enabled auto-merge (squash) March 24, 2026 18:26
@Sushisource
Sushisource merged commit acec0e6 into temporalio:master Mar 25, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants