CI: container image を :ci (slim) に切り替え (#46 の取りこぼし) - #48
Merged
Conversation
#45 published the slim base-stage image as :ci, and #46 was supposed to point build.yml at it — but the `:ci` switch commit dropped on the force-push during rebase, so master kept pulling :latest (the human- facing devcontainer image with zsh/clang-format/sudo/openssh-client/ curl baked in). CI still works because :latest contains a superset of what the build needs; this PR just trims the per-run image pull to the intended slim layers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#46 で CI を devcontainer image の中で動かすようにしたが、merge 時点で
container.image:の:latest→:ci切り替え commit が force-push のリベース中に落ちてマージされていなかった。master では今も:latest(= zsh / clang-format / sudo / openssh-client / curl 入りの fat image) を pull している。機能的には
:latest⊃:ci(同じ multi-stage Dockerfile のdevstage とbasestage) なので CI 自体は緑のままだが、毎回の image pull で dev ツール layer を引いていて目的の slim 化が達成されていない。変更
コメントも
:latest文脈から:ci文脈に書き直し。なぜローカル確認なしか
:citag は #45 でmasterマージ後に既に publish 済み (ghcr.io から anonymous pull で manifest HTTP 200 が返ることを確認済み)。違いは pull する layer set だけで、ビルド成功するかは GHA の container job が image を pull できるかの一点に集約される。なので CI 一発で検証可能。Test plan
:citag が pull できることの実証)