Skip to content

Phase 2: -Wignored-qualifiers を潰して -Werror=ignored-qualifiers を有効化 #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thawk105 merged 2 commits into from
May 14, 2026
Merged

Phase 2: -Wignored-qualifiers を潰して -Werror=ignored-qualifiers を有効化 #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7d7482
Phase 2: enable -Werror=ignored-qualifiers (cmake side)
thawk105 May 13, 2026
7874311
Phase 2: fix ignored-qualifiers in bomb workload headers
thawk105 May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmake/ProtocolHelpers.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ function(ccbench_add_protocol name)
-Werror=reorder
-Werror=unused-parameter
-Werror=catch-value
-Werror=unused-variable)
-Werror=unused-variable
-Werror=ignored-qualifiers)

set_property(TARGET ${target} PROPERTY CCBENCH_PROTOCOL "${name}")
set_property(TARGET ${target} PROPERTY CCBENCH_WORKLOAD "${wl}")
Expand Down
6 changes: 3 additions & 3 deletions include/bomb.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,15 +503,15 @@ public:
}
};

static const uint32_t get_i_id_product_start() {
static uint32_t get_i_id_product_start() {
return 1;
}

static const uint32_t get_i_id_material_start() {
static uint32_t get_i_id_material_start() {
return get_i_id_product_start() + FLAGS_bomb_product_size;
}

static const uint32_t get_i_id_work_start() {
static uint32_t get_i_id_work_start() {
return get_i_id_material_start() + FLAGS_bomb_material_size;
}

Expand Down
6 changes: 3 additions & 3 deletions include/bomb_pessimistic.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,15 +537,15 @@ public:
}
};

static const uint32_t get_i_id_product_start() {
static uint32_t get_i_id_product_start() {
return 1;
}

static const uint32_t get_i_id_material_start() {
static uint32_t get_i_id_material_start() {
return get_i_id_product_start() + FLAGS_bomb_product_size;
}

static const uint32_t get_i_id_work_start() {
static uint32_t get_i_id_work_start() {
return get_i_id_material_start() + FLAGS_bomb_material_size;
}

Expand Down
Loading