third_party: 未使用の spdlog submodule を除去 (#64 の一部) - #71
Merged
Conversation
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
issue #64 (third_party を FetchContent に移行) の To-do の最初の項目「`third_party/spdlog` submodule の利用調査 → 未使用なら submodule から外す」だけを切り出した PR です。#64 全体ではなく spdlog の件のみ。
調査結果: spdlog 参照は実質 0 件
issue 本文指定の grep と、CMake / build_tools / CI / Dockerfile まで広げた grep を実施:
```
$ grep -rn 'spdlog' include/ cc/ common/
include/logger.h:13:#include "spdlog/spdlog.h"
include/logger.h:17:static inline void setup_spdlog() {
include/logger.h:20: spdlog::set_level(spdlog::level::info);
include/logger.h:22: spdlog::set_level(spdlog::level::debug);
```
spdlog を参照しているのは `include/logger.h` のみ。さらに調べると:
つまり spdlog はビルドにまったく組み込まれておらず、唯一の参照元 `include/logger.h` 自体が orphan な dead code です。submodule として保持する理由がないため除去します。
変更内容
CMake / build_tools / CI / Dockerfile への参照は 0 件だったため、それらの変更はありません。
なお `include/logger.h` (どこからも使われていない dead code) と `docs/architecture_{ja,en}.md` の submodule 一覧記述は、本 PR のスコープ (submodule 除去) を超えるためあえて触れていません。別途整理対象です。
test plan
関連
#64 の一部 (#64 自体は close しません)