Skip to content

Fix/settings api auth#104

Open
anaghwadhwa123 wants to merge 1 commit into
thoth-tech:developmentfrom
anaghwadhwa123:fix/settings-api-auth
Open

Fix/settings api auth#104
anaghwadhwa123 wants to merge 1 commit into
thoth-tech:developmentfrom
anaghwadhwa123:fix/settings-api-auth

Conversation

@anaghwadhwa123

@anaghwadhwa123 anaghwadhwa123 commented Jul 24, 2026

Copy link
Copy Markdown

Description

This PR resolves an unauthenticated access vulnerability in the SettingsApi endpoint. Previously, the /settings endpoint was publicly accessible without authentication. By incorporating AuthenticationHelpers and enforcing before { authenticated? }, access to the configuration settings endpoint now strictly requires an authenticated user session.

Fixes Finding 6.6 in the Vulnerability Remediation Report.
Screenshot 2026-07-24 at 10 36 36 am

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Executed curl -i http://localhost:3000/api/settings without authentication headers.
  • Result: Confirmed the endpoint rejects unauthenticated requests, returning an internal 419 CUSTOM status code with the payload {"error":"No authentication details provided. Authentication is required to access this resource."}.
Screenshot 2026-07-24 at 10 25 52 am

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if appropriate
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have created or extended unit tests to address my new additions
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@anaghwadhwa123
anaghwadhwa123 force-pushed the fix/settings-api-auth branch from 33d2f70 to 218e50c Compare July 24, 2026 00:31
@anaghwadhwa123
anaghwadhwa123 force-pushed the fix/settings-api-auth branch from 218e50c to bc71306 Compare July 24, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant