Fixes from the post-merge review of #34 - #35
Open
thousandflowers wants to merge 1 commit into
Open
thousandflowers wants to merge 1 commit into
thousandflowers wants to merge 1 commit into
Conversation
A merged PDF claims a free name like every other output instead of writing over a photo.pdf already in the folder, and a move that ends in a merge removes the original once the one file is written; the refusal to overwrite says 'merges' when that is why. A name token needs two digits to mean quality: report_q3.pdf is a quarter, not a request for quality three. ⌘F reaches the block library's search field, which it never did. A join with steps after it keeps its remove button off, with the reason, rather than leaving those steps hanging off the fork. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BiYddy1XCmn5HzDtDpgAy8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four real defects found reviewing #34 by hand (the automated review hit the session limit):
<name>.pdf; a file already there was replaced. Now it goes throughreserveUniqueURLlike every other output. Test: an existingphoto.pdfsurvives, the merge lands as the next free name._q3read as quality 3. Name tokens for quality now need two digits (q10–q100);report_q3.pdfis a quarter. Test added.swift test: 378 tests, 0 failures.🤖 Generated with Claude Code
https://claude.ai/code/session_01BiYddy1XCmn5HzDtDpgAy8