Head in leaky layer - #74
Conversation
Can now compute heads for array of time and z. Only need to incorporate varying head on top of aquifer. Should probably be renamed headalongvertical
also renamed function to headinvertical and added example
add effect in top clay layer of head variation on top of semi-confined aquifer
|
Was this ready for review @mbakker7 ? |
|
Ready to review now! |
| h += htimml[:, np.newaxis] | ||
| return h | ||
|
|
||
| def headinvertical(self, x, y, z, t, aq=None, returneta=False): |
There was a problem hiding this comment.
I guess timflow currently uses a lot of headinvertical and headalongline naming styles. Just wondering out loud here whether we want to continue this trend, or move to a slightly longer but more legible style: head_in_vertical, head_along_line, etc. Maybe something for a separate issue (or a 1.0 version ... 😇 ).
There was a problem hiding this comment.
I was (am) not very fond of underscores, but function and variable names sometimes get long and unreadable. And it seems that a more accepted style is to have underscores. So indeed something we may want to revisit when we are approaching 1.0.
dbrakenhoff
left a comment
There was a problem hiding this comment.
Very cool! And looks good to me. I made two small (style/typo) changes, and asked a few general questions, but otherwise, fine to merge!
Compute variation of head in leaky layers through time. Include influx from overlying and underlying aquifers and loading efficiency.