Conversation
added 5 commits
January 17, 2018 20:12
- Renamed previous LICENSE file to be called NOTICE as required and suggested by Apache - Added the original Apache License 2.0 text as LICENSE text file
- Updated gradle and maven build to include Notice and License into binary jar output
- adjusted gradle build to also add notice and license to sources jar - maven source already contains notice and license file
- Fixed indenting in pom.xml of newly added reosurces section
- Fixed indentation of added properties in build.gradle file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followed the advice from Apache as stated in #285