-
Notifications
You must be signed in to change notification settings - Fork 2
fix(release): drop version requirements from intra-workspace path deps #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1506240
9aa3ab8
ce7a3cb
57f3a01
575141f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,8 +15,8 @@ readme = "../README.md" | |
| [dependencies] | ||
| # The contract. `tinymemory-core` implements and consumes it; the host seam | ||
| # traits (config, event sink, embeddings, chat) live in `tinymemory_api::host`. | ||
| tinymemory-api = { path = "../api", version = "0.1.1" } | ||
| tinymemory = { path = "..", version = "0.1.0" } | ||
| tinymemory-api = { path = "../api" } | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Restore version requirements on path dependencies These path dependencies dropped their [RULE] Keep path dependencies publishable · |
||
| tinymemory = { path = ".." } | ||
|
|
||
| # The default embedded engine. `store/`, `tree/` and `sync/` drive it directly; | ||
| # `tinycortex-api` is a direct dependency because `tinycortex::memory` aliases | ||
|
|
@@ -67,7 +67,7 @@ block2 = { version = "0.6", optional = true } | |
| [dev-dependencies] | ||
| # `TestHostConfig` — the concrete `MemoryHostConfig` the extracted test suites | ||
| # build, since `Config` is a trait object and cannot be `Default`ed. | ||
| tinymemory-api = { path = "../api", version = "0.1.1", features = ["test-support"] } | ||
| tinymemory-api = { path = "../api", features = ["test-support"] } | ||
| tempfile = "3" | ||
| tokio = { version = "1", features = ["test-util"] } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restore version requirement on the tinymemory-api path dependency
The original entry pinned the dependency with
version = "0.1.1"(a caret range). Removing the version field means the dependency is no longer pinned with a caret range, contrary to the repository rule. More importantly, if this crate is published to crates.io, Cargo requires every path dependency to specify a version requirement (unless it is a workspace member); without one,cargo publishwill fail. The surrounding comment indicates the crate is meant for external consumption, so publishing is a real path.[RULE] Dependencies should be pinned with a caret range; path dependencies intended for publishing need a version requirement. ·