Skip to content

chore(tinybus): advance to the attestation-capable bus - #22

Merged
senamakel merged 1 commit into
mainfrom
module-owns-the-key
Aug 14, 2026
Merged

chore(tinybus): advance to the attestation-capable bus#22
senamakel merged 1 commit into
mainfrom
module-owns-the-key

Conversation

@senamakel

@senamakel senamakel commented Aug 14, 2026

Copy link
Copy Markdown
Member

Why

The module ships as a pinned GitHub release artifact. Until
tinybus#15 that made it
permanently ineligible to receive a confidential message, whatever the host did.

Attestation was written only from a modules.toml beside the artifact. A
release download extracts into a fresh tempfile::TempDir, so allowlisted_hash
returned Ok(None) and the module was never attested — even though acquire had
verified the pinned digest twice, against the release's own checksum.toml and
against the downloaded bytes, before extracting anything.

So a module built against the old bus can never be sent key material. This bump
is the prerequisite for moving derivation and signing in here; on its own it
changes no behaviour.

What comes with it

PR
#10 confidential messages delivered only to hash-verified modules
#12 lazy modules
#13 confidential stream refusal
#15 pinned-release attestation

Not in this PR

The wire surface is unchanged — still BuildUnsigned and AttachSignature, still
no method that accepts key material. Exposing derivation and signing over
confidential calls is the next change, and it is a wire-contract change that
deserves its own review.

Verification

cargo build -p tinywallet-module     clean
cargo test --workspace               334 passed, 0 failed

Summary by CodeRabbit

  • Chores
    • Updated an internal vendor component to a newer version.
    • No user-facing features or behavior changes were introduced.

Picks up confidential messages (#10), lazy modules (#12), confidential
stream refusal (#13), and the pinned-release attestation (#15).

#15 is the one that matters for this module. Attestation was previously
written only from a `modules.toml` beside the artifact; a module loaded
from a GitHub release extracts into a fresh temporary directory that has
no such file, so it was never attested and every confidential call to it
was refused. This module ships exactly that way, so a build against the
old bus can never be sent key material however the host is configured.

Co-authored-by: Medulla <medulla@tinyhumans.ai>

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

$0.0000 · 0 in / 0 out

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Aug 14, 2026
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0eff2474-ca3b-4f7a-89eb-21209a48c27e

📥 Commits

Reviewing files that changed from the base of the PR and between 2a5e033 and 13a8472.

📒 Files selected for processing (1)
  • vendor/tinybus

📝 Walkthrough

Walkthrough

The PR updates the vendor/tinybus submodule pointer from commit 6ca0b0b6739a49396e36be21d450f07cf85b9de2 to commit c35105f95b5efd49f63aec3f82f8bc2154694977.

Changes

tinybus update

Layer / File(s) Summary
Update tinybus submodule reference
vendor/tinybus
The submodule pointer changes to a different commit.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: 🔵 Low · up to 13a84

This update allows verified release-pinned modules to become eligible for confidential messages while leaving the current wallet API and key-material handling unchanged. It is mergeable with owner awareness, but the security-sensitive dependency transition should have its provenance, compatibility, and targeted TinyBus behavior checks confirmed before or alongside merge.

Poem

A rabbit hops past tinybus bright,
A pointer shifts to newer light.
One small commit, one tidy trail,
No tangled roots, no broken rail.
Hop, hop— the update sails!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the tinybus update to an attestation-capable version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@senamakel
senamakel merged commit b7eee67 into main Aug 14, 2026
16 checks passed
@senamakel
senamakel deleted the module-owns-the-key branch August 14, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant