Skip to content

virtualenv --quiet for windows #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkf merged 2 commits into from
Mar 21, 2014
Merged

virtualenv --quiet for windows #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1739d62
Add --quiet option by default for Windows
tkf Mar 21, 2014
66e33a8
Add --verbose when python-environment--verbose is t
tkf Mar 21, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions python-environment.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,10 @@ Thus, typically the default virtual environment path is
:group 'python-environment)

(defcustom python-environment-virtualenv
(list "virtualenv" "--system-site-packages")
(list "virtualenv" "--system-site-packages" "--quiet")
;; --quiet is required for Windows. Without it, virtualenv raises
;; UnicodeEncodeError
;; See: https://github.com/tkf/emacs-jedi/issues/148#issuecomment-38290546
"``virtualenv`` command to use, including command options. List of strings.

For example, if you want to use specific Python executable (to
Expand Down Expand Up @@ -111,7 +114,9 @@ https://github.com/tkf/emacs-python-environment/issues/3"
(defun python-environment--make-with-runner (proc-runner root virtualenv)
(let ((path (convert-standard-filename
(python-environment-root-path root)))
(virtualenv (or virtualenv python-environment-virtualenv)))
(virtualenv (append (or virtualenv python-environment-virtualenv)
(when python-environment--verbose
(list "--verbose")))))
(unless (executable-find (car virtualenv))
(error "Program named %S does not exist." (car virtualenv)))
(funcall proc-runner
Expand Down