Feat int minimization - #303
Merged
Merged
Conversation
bennn
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the optimization features described here. The set-based optimization is still somewhat brittle, but the feature should be made available in preview form.
Known issues:
This PR also fixes the verbosity level that triggers collector spam for debugging;
5("HIGH") will no longer be enough.Finally, this PR also expands the
run-tests.shscript to no longer attempt to run the SMT backend tests ifcvc5is not on the path. (Aside: I don't have a lot of shell-script experience beyond the basics, so this is a place I would like to request extra review effort.)