Avoid identifier clash between expander macros and user-defined sigs, etc. - #307
Merged
Merged
Conversation
tnelson
added a commit
that referenced
this pull request
Jun 16, 2025
This PR will also add #307, avoiding identifier-name clashes. This PR also includes auto-loading CnD visualizer specs to Sterling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present, if the user names a
sigorpredusing the same name as an expander macro in Forge, there are various bad behaviors that come up (and because of the nature of macros, the behavior is not always amenable to easy diagnosis). While it is possible we could do something "better" in Racket to avoid this, it seems effective to rename internal expander macros to identifiers that are not Forge identifiers. E.g., this PR renamesExprtoNT-Expr(short for "non-terminal", since it comes from the parser).Two new test files check a variety of internal identifiers declared as both sigs and preds.
This PR also moves two very old, unused, subfolders of the Forge package (
testmeandcheck-ex-spec) out of the main package folder.