This repository was archived by the owner on Dec 27, 2019. It is now read-only.
L-BFGS#12
Merged
Merged
Conversation
Contributor
Author
|
Ready for review. Currently uses the golden ratio line search to determine step size, we could consider a trust region as well. |
to266
suggested changes
Nov 28, 2018
to266
left a comment
Owner
There was a problem hiding this comment.
LGTM, just one trivial comment below.
Thanks for the PR!
| loop { | ||
| let dir = self.quasi_update(&g, &hist); | ||
| let a = { | ||
| let min = ::scalar::GoldenRatioBuilder::default() |
Owner
There was a problem hiding this comment.
How about moving this minimizer implementation outside the loop? Not sure this works, but I don't see any obvious reasons why not.
Contributor
Author
There was a problem hiding this comment.
It has to do with ownership; min is passed a reference to x, so as long as min lives, x can not be mutated. That's why the whole shebang is in a block returning a.
to266
approved these changes
Dec 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a limited-memory BFGS variant. First step towards an L-BFGS-B routine. #2
TODO