Conversation
disktree asks for server-side decorations, and Hyprland, KDE, X11 window managers, macOS and Windows draw a title bar for it. GNOME's Mutter does not offer server-side decorations to Wayland apps, so GPUI falls back to client-side ones and disktree drew none: no minimize, maximize or close, no way to move the window by its header, and no resize edges. When the window reports client-side decorations, each screen's header now acts as the title bar. A drag moves the window once the pointer travels a few pixels, so a click on a crumb stays a click. Double-click maximizes, right-click opens the compositor's window menu, and the controls the compositor supports sit at the header's right end. The free edges and corners resize the window. Presses on the header's buttons never reach the title bar, so double-clicking a crumb does not maximize the window. Under server-side decorations nothing changes. The test window always reports server-side decorations, so a test-only field lets the harness stand in for GNOME. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nothing in the window could be selected, so a path seen in the panel had to be retyped to use it anywhere else. The selection's name and path, the marked list, the review list, the removal log and failures, the disk figures, notices and the key bar are now selectable, and Ctrl+C (Cmd+C, also in a new Edit menu on macOS) copies the selection. With nothing selected the chord is left alone. This is gpui-kit's own window-wide text selection: one layer at the root and a selectable run per piece of text. The layer moves a selection as the pointer drags but leaves the redraw to the app, so the root refreshes the window while a selection is being dragged; without that the highlight lagged until something else repainted. Text stays plain where a press already means something: buttons, crumbs, clickable rows, the title bar, the tooltip that follows the pointer, and the treemap, whose labels are painted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have really enjoyed this app! I suspect you did it for https://omarchy.us/ + Hyprland but I was enjoying it on https://nixos.org/ + Wayland.
Here are two fixes for running disktree on GNOME (Wayland).
Window controls where the compositor draws none
disktree asks for server-side decorations. Hyprland, KDE, X11 window
managers, macOS and Windows draw a title bar for it. GNOME's Mutter does
not offer server-side decorations to Wayland apps, so GPUI falls back to
client-side ones, and disktree drew nothing: no minimize, maximize or
close, no way to move the window, no resize edges.
When the window reports client-side decorations, each screen's header is
now the title bar:
compositor says it supports
Presses on the header's crumbs and settings never reach the title bar,
so double-clicking a crumb does not maximize the window. Under
server-side decorations nothing changes.
Selectable text and Ctrl+C
Nothing could be selected, so a path in the panel had to be retyped.
This uses gpui-kit's own window-wide text selection (
TextSelectionLayerplus
SelectableText). The selection's name and path, the marked andreview lists, the removal log and failures, the disk figures, notices
and the key bar are selectable. Ctrl+C (Cmd+C, with an Edit menu on
macOS) copies; with nothing selected the chord is left alone and is not
read as
c.gpui-kit moves a selection as the pointer drags but leaves the redraw to
the app, so the root refreshes the window during a selection drag;
without it the highlight lagged.
Text stays plain where a press already means something: buttons, crumbs,
clickable rows, the title bar, the cursor tooltip, and the painted
treemap.
Testing
cargo xtask lintandcargo xtask testpass on each commit.server-side decorations (the test window panics if asked to move);
controls and resize handles under client-side decorations, standing in
for GNOME through a test-only field; a drag across the selection's
name and path followed by Ctrl+C copies exactly that text.
threshold.
close, resize, select and copy. Not tried on Windows or macOS beyond
CI, or on Hyprland by hand.
Screenshots
The controls in the header on GNOME, and a selection in the panel.