fix(provider): enforce chunk timeout regardless of content type - #4
Merged
Merged
Conversation
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Upstream PR: anomalyco#47621
Upstream issue: anomalyco#47605
Type of change
What does this PR do?
Bring the upstream timeout fix into our fork so we can use it before upstream merges it.
chunkTimeoutcurrently only checks responses markedtext/event-stream. If a provider omits or mislabels that header, a stalled response can leave the session waiting indefinitely.Remove the header check so the existing timeout covers all response bodies through the SDK fetch wrapper, including Bedrock binary streams and JSON. Timeout defaults and opt-outs are unchanged. Native and WebSocket transports are outside this change.
This is the same reviewed commit as the upstream PR:
e22295a175b74090549115e0eb02b64af6aefb3e. It merges cleanly with the fork’s CI and self-update changes.How did you verify your code works?
bun typecheckpassed inpackages/opencode.The full run used a worktree-local
TMPDIRafter/tmpfilled, which affected unrelated tests. A clean-environment full-suite pass remains unverified. These test results are for the fix commit before merging with the fork’s additional changes; fork CI must check the combined result.Checklist