fix: keep --json output parseable on stdout#286
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
3794a87 to
64123af
Compare
| /// Writes a human-readable rendering of some data, or the data itself as JSON when | ||
| /// in JSON mode. Use this when a command's output is data that has both a plain text | ||
| /// and a JSON representation, mirroring `table` and `list`. | ||
| pub fn text<T: Serialize>(msg: &str, json_data: &T) { |
Contributor
There was a problem hiding this comment.
Ah ok I made something similar in my PR and after this I can probably remove it
This was referenced Jul 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--jsonis supposed to mean "stdout is JSON you can parse". Several commands broke that promise by mixing raw text into the output.tower run --detached --jsonprinted a "See more" link after the success JSON.tower run --jsonagainst a missing app printed remediation steps after the error JSON.tower schedules list --jsonprinted "No schedules found." instead of[].tower teams list --jsonprinted the active-team legend after the data. Andtower version --jsonwasn't JSON at all.The root cause is the same everywhere:
output::write()knows about MCP mode but not JSON mode. Instead of special-casing call sites, the broken sites now go through JSON-aware output functions. output.rs gains two:text()writes a human rendering or the data as JSON (the same shape astable()andlist()), andnote()writes presentation-only text that JSON mode suppresses. The run link travels inside the success message, with the scheduled run as structureddata.The new integration tests run each case with
--jsonand parse stdout. Puttingteams listunder test required updating the mock server's/v1/session/refreshresponse, which had drifted from the generated client models. flake.lock gets a nixpkgs bump so binaryen comes from the binary cache on aarch64-darwin instead of compiling LLVM from source.