fix: correctly detect which catalogs we should vend credentials for

[konstantinoscs]

The problem was that we try to vend credentials for all tables in the tables() call so it messed up s3 tables. This fixes that

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5b8cf5a0-ff53-4702-a548-5c0d9feedbab

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/tow-2325-regression-in-0368-causes-s3tables-catalogs-to-incorrectly

---

_{Comment @coderabbitai help to get the list of available commands.}

[bradhe]

Do we want to get this out for diagnostic purposes somehow? I'm not really sure how this call could fail.

[konstantinoscs]

I'm not sure what you mean? If we want to report it?

[socksy]

like if you hit this exception let's log something or die louder rather than swallow it and pretend nothing went wrong, since it shouldn't break in usual usage

[konstantinoscs]

I added a log here. But we should not die loudly:

We use this function to answer: “Is this string catalog a Tower-managed tower-catalog, so we should vend Tower credentials, or is it BYO/S3 Tables, so we should use PyIceberg config?”
If the probe fails, we still have a valid fallback path: check for PyIceberg config and then call load_catalog(). That’s especially important for BYO/S3 Tables customers, because their catalog may work perfectly through runner-injected PYICEBERG_CATALOG__... config even if Tower’s describe API is unavailable, unauthorized, stale, or temporarily failing.