Fix generateKey - #2319
Open
jpantonow wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix generateKey
Repository:
treehouses/remoteType: Pull request
Analysis context
generateKeyio.treehouses.remote.bases.BaseSSHKeyGenapp/src/main/kotlin/io/treehouses/remote/bases/BaseSSHKeyGen.ktKeyPairGeneratorSpecapeProposed change
The runtime error confirms that
initialize(bitSize)rejected the selected DSA key size. When the requested algorithm is DSA, the method now initializes it with the supported 2048-bit size while leaving the caller-provided size unchanged for all other algorithms.Validation
Additional context
I’m an undergraduate Computer Engineering student at the University of Brasília (UnB), and this contribution is part of a research project involving software security analysis.
I’m happy to adjust the implementation to better match the project’s architecture, coding conventions, or maintainers’ recommendations.