Skip to content

fix(build): replace tsconfck with native typescript config parsing to support ts 6#3967

Closed
Rahulchaudharyji2 wants to merge 1 commit into
triggerdotdev:mainfrom
Rahulchaudharyji2:fix/ts6-build-peer-dep
Closed

fix(build): replace tsconfck with native typescript config parsing to support ts 6#3967
Rahulchaudharyji2 wants to merge 1 commit into
triggerdotdev:mainfrom
Rahulchaudharyji2:fix/ts6-build-peer-dep

Conversation

@Rahulchaudharyji2

Copy link
Copy Markdown

Closes #3953

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

  1. Force rebuilt the @trigger.dev/build package successfully:
    pnpm run build --force --filter @trigger.dev/build
    
  2. Ran package typecheck successfully (0 errors):
     pnpm run typecheck --filter @trigger.dev/build
    
  3. Ran the E2E decorators metadata tests in packages/cli-v3 to verify config resolution and decorator transpilation behaves exactly as before:
     MOD=emit-decorator-metadata pnpm run test:e2e
    

Result: Passed successfully.


Changelog

Removed tsconfck dependency from @trigger.dev/build to fix the peer dependency installation conflict when using TypeScript 6 and pnpm.
Implemented native tsconfig.json parsing in typescript.ts using the already runtime-imported typescript package APIs (findConfigFile, readConfigFile, and parseJsonConfigFileContent).
Added Map-based caching for resolved compiler options to avoid duplicate disk reads and parsing.

💯

@changeset-bot

changeset-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f0a875e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@trigger.dev/build Patch
trigger.dev Patch
@trigger.dev/python Patch
@trigger.dev/core Patch
@trigger.dev/plugins Patch
@trigger.dev/react-hooks Patch
@trigger.dev/redis-worker Patch
@trigger.dev/rsc Patch
@trigger.dev/schema-to-json Patch
@trigger.dev/sdk Patch
@trigger.dev/database Patch
@trigger.dev/otlp-importer Patch
@trigger.dev/rbac Patch
@internal/cache Patch
@internal/clickhouse Patch
@internal/llm-model-catalog Patch
@internal/redis Patch
@internal/replication Patch
@internal/run-engine Patch
@internal/schedule-engine Patch
@internal/testcontainers Patch
@internal/tracing Patch
@internal/tsql Patch
@internal/zod-worker Patch
@internal/sdk-compat-tests Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1ceefeae-38c0-42cd-bc72-a6dd53f3d6f5

📥 Commits

Reviewing files that changed from the base of the PR and between 19c0763 and f0a875e.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • .changeset/afraid-bags-pretend.md
  • packages/build/package.json
  • packages/build/src/extensions/typescript.ts

Walkthrough

The tsconfck package is removed from packages/build/package.json. The emitDecoratorMetadata build extension in packages/build/src/extensions/typescript.ts is updated to use TypeScript's native APIs—findConfigFile, readConfigFile, parseJsonConfigFileContent, and sys—to locate and parse tsconfig.json files, with results cached per config path. The onLoad handler now derives the search path from the loaded file, conditionally skips transpilation if emitDecoratorMetadata is not set in the resolved options, and passes the computed compilerOptions to transpileModule. A changeset file is added documenting this as a patch to @trigger.dev/build.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor

Hi @Rahulchaudharyji2, thanks for your interest in contributing!

This project requires that pull request authors are vouched, and you are not in the list of vouched users.

This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@trigger.dev/build depends on tsconfck 3.1.3, blocking TypeScript 6 with strict peer deps

1 participant