Conversation
…nd programmatic sound triggers
- Add hardware audio capability modeling (none, piezo, full) to devices
- Support native Pixlet sound discovery (schema.Sound and schema.Notification)
- Add Option A smart fallback for piezo devices (keyword tone mapping and pleasant 2-tone chime)
- Implement unified sound routes GET /sounds/{appId}/{filename} and GET /api/sounds/{filename}
- Support admin custom sound management (upload, delete, preview)
- Add sound trigger parameters to POST /v0/devices/{id}/sound, push_app, and push
- Support sound playback trigger on render (on_change or every_render) with SHA-256 change detection
- Include comprehensive unit tests and documentation in API.md
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
…and tagalign issues
… and movie sonar ping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds end-to-end notification sound support:
none,piezo, andfullhardware audio capabilities for devices.schema.Soundandschema.Notificationin Starlark apps.ding,chime,bell,alert,pop) with a pleasant 2-tone chime fallback (659:120,880:180).GET /sounds/{appId}/{filename}andGET /api/sounds/{filename}with strict path traversal protection.soundparameter toPOST /v0/devices/{id}/push_appandPOST /v0/devices/{id}/push(ideal for real-time events like sports score notifications).POST /v0/devices/{id}/soundto acceptapp_idand stream URLs.Testing
sounds_test.gocovering payload resolution, Option A piezo fallbacks, schema extraction, push integration, and unified route serving.go test ./internal/server/...).