Repository navigation
Make the firmware version reported by GET VERSION configurable - #48
Open
FlorianFranzen wants to merge 1 commit into
Open
FlorianFranzen wants to merge 1 commit into
FlorianFranzen wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clients gate features on the version reported by the Yubico GET VERSION extension: ykman and yubico-piv-tool assume a 3DES default management key below 5.7 and AES-192 from 5.7 on, GET METADATA is only used from 5.3 on, and yubikey.rs refuses serial retrieval for any major version other than 4 and 5. The hardcoded
6.6.6therefore locks those clients out entirely; neither an honest 0.x nor a made-up 6.x works.This exposes the reported version as an
Optionsfield so a runner can choose one whose feature set matches what the app implements (with this crate's current feature set,5.4.0is a good choice for Yubico-ecosystem deployments). The default stays6.6.6, so nothing changes without opting in.Tested in
command_response.ronfor both a configured version and the default.