test(api): add fixture to exercise anti-slop CI gate - #155
Closed
github-actions[bot] wants to merge 1 commit into
Closed
test(api): add fixture to exercise anti-slop CI gate#155github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Deliberately sloppy file covering five rules at once. This branch exists so the red CI run and its inline annotations can be inspected. It must never be merged.
Collaborator
|
Demo served its purpose — the gate from #153 fails CI on real slop, with inline annotations, and stops before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge. Do not delete yet. This branch exists purely so the anti-slop gate from #153 can be inspected failing, on a real PR, with real annotations.
It adds one deliberately sloppy file,
apps/api/src/zz-slop-demo.ts, covering five rules at once:no-unsafe-dictionary-typetype Settings = Record<string, unknown>no-unknown-parametersreadSettings(value: unknown)no-runtime-typeoftypeof value === "object"standing in for a parserno-chained-type-assertionssettings.label as unknown as stringno-conditional-empty-object-spread...(tag ? { industry: tag } : {})in a PrismawhereWhat to look at
check-types, lint, testcheck is red, and it failed on thebun run lint:slopstep.bun run testnever ran. The job usesshell: /usr/bin/bash -e, so it aborts at the first failing step — slop fails fast rather than burning the full suite first.Worth knowing
Getting this branch pushed at all required
--no-verify. The pre-push hook refused it first, with the same failure — so this red run only happens for someone who deliberately bypassed the local check and then ignored CI.Close and delete the branch whenever you have seen enough.