Expose gateway controllers as interfaces#441
Merged
Merged
Conversation
Convert the six gateway controllers (ping, cancel, list, land, request_summary, request_history) from concrete structs to exported interfaces backed by unexported implementations, with constructors now returning the interface type. This lets consumers generate gomock mocks for these controllers via mockgen. gomock can only mock interfaces, so as concrete structs they were unmockable, forcing downstream services (e.g. Uber's internal go-code sq-gateway) to hand-write wrapper interfaces solely to enable mocking. Exposing the interfaces here removes the need for those wrappers. Behavior is unchanged: constructors still return pointer-backed implementations, so no copying occurs; only the declared API surface changed. The GatewayServer fields and affected tests were updated to the interface types accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ubettigole
marked this pull request as ready for review
July 24, 2026 19:14
ubettigole
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
July 24, 2026 19:14
behinddwalls
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert the six gateway controllers (ping, cancel, list, land, request_summary, request_history) from concrete structs to exported interfaces backed by unexported implementations, with constructors now returning the interface type. This makes mocking in unit tests easier for callers.
Behavior is unchanged: constructors still return pointer-backed implementations, so no copying occurs; only the declared API surface changed. The GatewayServer fields and affected tests were updated to the interface types accordingly.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
Test Plan
Unit tested
Issues