Add CODE OWNERS file - #3
Merged
Merged
Conversation
Add Code Owners based on Github teams (@uber/submitqueue-admins @uber/submitqueue-maintainers)
yushan8
approved these changes
Jan 27, 2026
xytan0056
added a commit
that referenced
this pull request
Sep 11, 2026
Replace setutil with a minimal printer package in the fixture and update the head SHA to match bazel-fixture PR #3's force-push. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
xytan0056
added a commit
that referenced
this pull request
Sep 11, 2026
Add a separate integration test suite that exercises the AllTargetsFiles code path end-to-end against bazel-fixture PR #3, which changes .bazelrc (a configured all_targets_files trigger), adds pkg/printer, and deletes pkg/version in the same revision. The test verifies that NEW and DELETED change types are preserved when the global trigger fires, while targets present in both revisions are promoted to CHANGED at distance 0. Changes: - integration/atf_test.go: dedicated test file with sha and PR subtests - integration/BUILD.bazel: separate atf_test Bazel target, shared deps - integration/testdata/tango-config.yaml.tmpl: add all_targets_files - Makefile: split INTEGRATION_ENV/ATF_ENV, add test-integration-atf
xytan0056
added a commit
that referenced
this pull request
Sep 11, 2026
Add a separate integration test suite that exercises the AllTargetsFiles code path end-to-end against bazel-fixture PR #3, which changes .bazelrc (a configured all_targets_files trigger), adds pkg/printer, and deletes pkg/version in the same revision. The test verifies that NEW and DELETED change types are preserved when the global trigger fires, while targets present in both revisions are promoted to CHANGED at distance 0. Changes: - integration/atf_test.go: dedicated test file with sha and PR subtests - integration/BUILD.bazel: separate atf_test Bazel target, shared deps - integration/testdata/tango-config.yaml.tmpl: add all_targets_files - Makefile: split INTEGRATION_ENV/ATF_ENV, add test-integration-atf
xytan0056
added a commit
that referenced
this pull request
Sep 11, 2026
Add a separate integration test suite that exercises the AllTargetsFiles code path end-to-end against bazel-fixture PR #3, which changes .bazelrc (a configured all_targets_files trigger), adds pkg/printer, and deletes pkg/version in the same revision. The test verifies that NEW and DELETED change types are preserved when the global trigger fires, while targets present in both revisions are promoted to CHANGED at distance 0. Changes: - integration/atf_test.go: dedicated test file with sha and PR subtests - integration/BUILD.bazel: separate atf_test Bazel target, shared deps - integration/testdata/tango-config.yaml.tmpl: add all_targets_files - Makefile: split INTEGRATION_ENV/ATF_ENV, add test-integration-atf
xytan0056
added a commit
that referenced
this pull request
Sep 11, 2026
Add a separate integration test suite that exercises the AllTargetsFiles code path end-to-end against bazel-fixture PR #3, which changes .bazelrc (a configured all_targets_files trigger), adds pkg/printer, and deletes pkg/version in the same revision. The test verifies that NEW and DELETED change types are preserved when the global trigger fires, while targets present in both revisions are promoted to CHANGED at distance 0. Changes: - integration/atf_test.go: dedicated test file with sha and PR subtests - integration/BUILD.bazel: separate atf_test Bazel target, shared deps - integration/testdata/tango-config.yaml.tmpl: add all_targets_files - Makefile: split INTEGRATION_ENV/ATF_ENV, add test-integration-atf
xytan0056
added a commit
that referenced
this pull request
Sep 17, 2026
## Summary - Add a separate integration test suite exercising the AllTargetsFiles code path end-to-end against [bazel-fixture PR #3](xytan0056/bazel-fixture#3), which changes `.bazelrc` (a configured `all_targets_files` trigger), adds `pkg/printer`, and deletes `pkg/version` in the same revision. - Verify that `NEW` and `DELETED` change types are preserved when the global trigger fires, while targets present in both revisions are promoted to `CHANGED` at distance 0. - Split integration env vars so each suite only receives its own SHAs/URLs. ## Test Plan CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Code Owners based on Github teams (@uber/submitqueue-admins @uber/submitqueue-maintainers)