Skip to content

fix(urunc-deploy): correctly parse containerd major version - #1072

Merged
cmainas merged 2 commits into
urunc-dev:main-pr1072from
slash-init:fix/1071-containerd-version-detection
Oct 2, 2026
Merged

cmainas merged 2 commits into
urunc-dev:main-pr1072from
slash-init:fix/1071-containerd-version-detection

Conversation

@slash-init

Copy link
Copy Markdown
Contributor

Description

The containerd runtime version parsing in urunc-deploy incorrectly extracts multiple version components from the runtime version string.
For example, containerd://2.3.4-k3s1.36 was parsed into multiple values, causing the version comparison to fail with [: too many arguments.
This change updates the version extraction to parse only the major containerd version following containerd://.

Related issues

How was this tested?

The version extraction was manually verified with the following runtime versions:

  • containerd://2.3.4-k3s1.36 → 2
  • containerd://1.7.20 → 1
  • containerd://2.0.0 → 2
    The resulting version comparison was also verified for containerd 1.x and 2.x.
    Additionally:
  • bash -n passed.
  • git diff --check passed.
  • No unrelated files were modified.

LLM usage

GPT 5.6 Lua was used to assist with investigating the issue.

Checklist

Fixes: urunc-dev#1071
Signed-off-by: slash <amvermagaurav007@gmail.com>
@netlify

netlify Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for urunc canceled.

Name Link
🔨 Latest commit 0d3125e
🔍 Latest deploy log https://app.netlify.com/projects/urunc/deploys/6abeadfb11b7d4000887bba6

@cmainas

cmainas commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Thank you @slash-init ,

can you add yourself in https://github.com/urunc-dev/urunc/blob/main/.github/contributors.yaml So we can merge this?

Signed-off-by: slash <amvermagaurav007@gmail.com>
@slash-init

Copy link
Copy Markdown
Contributor Author

Thank you @slash-init ,

can you add yourself in https://github.com/urunc-dev/urunc/blob/main/.github/contributors.yaml So we can merge this?

Done.

@urunc-bot
urunc-bot Bot changed the base branch from main to main-pr1072 October 2, 2026 07:04

@cmainas cmainas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @slash-init for the fix.

@cmainas
cmainas merged commit 471d57b into urunc-dev:main-pr1072 Oct 2, 2026
47 of 51 checks passed
github-actions Bot pushed a commit that referenced this pull request Oct 2, 2026
PR: #1072
Fixes: #1071
Signed-off-by: slash <amvermagaurav007@gmail.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
github-actions Bot pushed a commit that referenced this pull request Oct 2, 2026
PR: #1072
Signed-off-by: slash <amvermagaurav007@gmail.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
urunc-bot Bot pushed a commit that referenced this pull request Oct 2, 2026
PR: #1072
Fixes: #1071
Signed-off-by: slash <amvermagaurav007@gmail.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
urunc-bot Bot pushed a commit that referenced this pull request Oct 2, 2026
PR: #1072
Signed-off-by: slash <amvermagaurav007@gmail.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
@slash-init
slash-init deleted the fix/1071-containerd-version-detection branch October 2, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The containerd version detection in urunc-deploy does not parse correctly the version string

2 participants