Conversation
Fixes: urunc-dev#1071 Signed-off-by: slash <amvermagaurav007@gmail.com>
✅ Deploy Preview for urunc canceled.
|
Contributor
|
Thank you @slash-init , can you add yourself in https://github.com/urunc-dev/urunc/blob/main/.github/contributors.yaml So we can merge this? |
Signed-off-by: slash <amvermagaurav007@gmail.com>
Contributor
Author
Done. |
cmainas
approved these changes
Oct 2, 2026
cmainas
left a comment
Contributor
There was a problem hiding this comment.
Thank you @slash-init for the fix.
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 2, 2026
PR: #1072 Signed-off-by: slash <amvermagaurav007@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
urunc-bot Bot
pushed a commit
that referenced
this pull request
Oct 2, 2026
PR: #1072 Signed-off-by: slash <amvermagaurav007@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The containerd runtime version parsing in
urunc-deployincorrectly extracts multiple version components from the runtime version string.For example,
containerd://2.3.4-k3s1.36was parsed into multiple values, causing the version comparison to fail with[: too many arguments.This change updates the version extraction to parse only the major containerd version following
containerd://.Related issues
How was this tested?
The version extraction was manually verified with the following runtime versions:
containerd://2.3.4-k3s1.36→2containerd://1.7.20→1containerd://2.0.0→2The resulting version comparison was also verified for containerd 1.x and 2.x.
Additionally:
bash -npassed.git diff --checkpassed.LLM usage
GPT 5.6 Lua was used to assist with investigating the issue.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).