fix(unikernels): reject non-contiguous subnet masks in subnetMaskToCIDR - #950
Open
KHARSHAVARDHAN-eng wants to merge 1 commit into
Open
KHARSHAVARDHAN-eng wants to merge 1 commit into
KHARSHAVARDHAN-eng wants to merge 1 commit into
Conversation
subnetMaskToCIDR() computed the prefix length by counting set bits without checking for contiguity. As a result, non-contiguous masks like 255.0.255.0 were accepted as /16. Refactor subnetMaskToCIDR() using net.ParseIP and net.IPMask.Size() to validate both mask format and contiguity. Add comprehensive unit tests covering canonical, non-contiguous, and malformed masks. Fixes urunc-dev#909 Signed-off-by: Harsha Vardhan <harshahvk2005@gmail.com>
✅ Deploy Preview for urunc canceled.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #909
Summary
subnetMaskToCIDR()inpkg/unikontainers/unikernels/utils.gopreviously computed the prefix length by counting set bits without verifying contiguity. As a result, structurally invalid non-contiguous subnet masks (such as255.0.255.0or0.255.255.255) were silently accepted and mapped to incorrect CIDR prefix lengths instead of being rejected.Solution
subnetMaskToCIDR()to parse the subnet mask usingnet.ParseIP()and validate contiguity vianet.IPMask.Size(). Non-contiguous masks causemask.Size()to return(0, 0), which is now detected and returned as a validation error (invalid (non-contiguous) subnet mask).utils_test.gocovering canonical masks (/0to/32), non-contiguous masks, and malformed string inputs.