fix: rebase PR #84 - SmsGatewayHub SMS adapter - #141
Closed
deepshekhardas wants to merge 1 commit into
Closed
Conversation
Original by @kevinjosephjohn. Fixed: - Added parent::__construct() call - Made properties private readonly - Removed error_log debugging calls - Fixed test to use env vars with skippable check - Aligned with v2.0.0 conventions
|
Thanks for contributing! This repository is a read-only mirror; development for this library happens in |
Greptile SummaryAdds an SMSGatewayHub adapter and its credential-gated integration test.
Confidence Score: 5/5The pull request appears safe to merge, with no concrete actionable defects identified in the changed code. The adapter follows the repository’s established SMS lifecycle and response conventions, while the available evidence does not establish a reachable provider-contract or runtime failure. Important Files Changed
Reviews (1): Last reviewed commit: "fix: rebase PR #84 - SmsGatewayHub SMS a..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for #84. Original by @kevinjosephjohn.
Rebased on latest main. Fixed: