Skip to content

fix: rebase PR #84 - SmsGatewayHub SMS adapter - #141

Closed
deepshekhardas wants to merge 1 commit into
utopia-php:mainfrom
deepshekhardas:fix/pr-84-rebase
Closed

fix: rebase PR #84 - SmsGatewayHub SMS adapter#141
deepshekhardas wants to merge 1 commit into
utopia-php:mainfrom
deepshekhardas:fix/pr-84-rebase

Conversation

@deepshekhardas

Copy link
Copy Markdown

Replacement for #84. Original by @kevinjosephjohn.

Rebased on latest main. Fixed:

  • Added parent::__construct() call
  • Made properties private readonly
  • Removed error_log debugging calls
  • Fixed test to use env vars with skippable check
  • Aligned with v2.0.0 conventions

Original by @kevinjosephjohn.

Fixed:
- Added parent::__construct() call
- Made properties private readonly
- Removed error_log debugging calls
- Fixed test to use env vars with skippable check
- Aligned with v2.0.0 conventions
@github-actions

Copy link
Copy Markdown

Thanks for contributing! This repository is a read-only mirror; development for this library happens in packages/messaging in the utopia-php monorepo. Please open this pull request there instead.

@github-actions github-actions Bot closed this Jul 23, 2026
@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown

Greptile Summary

Adds an SMSGatewayHub adapter and its credential-gated integration test.

  • Builds SMSGatewayHub GET requests with configured routing and DLT parameters.
  • Normalizes and batches up to 100 recipients.
  • Converts transport outcomes into the standard messaging response format.
  • Skips the live integration test when required environment variables are unavailable.

Confidence Score: 5/5

The pull request appears safe to merge, with no concrete actionable defects identified in the changed code.

The adapter follows the repository’s established SMS lifecycle and response conventions, while the available evidence does not establish a reachable provider-contract or runtime failure.

Important Files Changed

Filename Overview
src/Utopia/Messaging/Adapter/SMS/SmsGatewayHub.php Adds the provider adapter with request construction, recipient normalization, batching, and standard response mapping; no concrete changed-code defect was established.
tests/Messaging/Adapter/SMS/SmsGatewayHubTest.php Adds a skippable environment-backed integration test for successful SMS delivery.

Reviews (1): Last reviewed commit: "fix: rebase PR #84 - SmsGatewayHub SMS a..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant