Skip to content

fix: address redox build issues - #14620

Open
xtqqczze wants to merge 2 commits into
uutils:mainfrom
xtqqczze:redox-cast
Open

fix: address redox build issues#14620
xtqqczze wants to merge 2 commits into
uutils:mainfrom
xtqqczze:redox-cast

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

These changes are intended to help restore successful builds on Redox.

RUSTC_BOOTSTRAP=1 cargo clippy -q -Zbuild-std --all-targets --features feat_os_unix_redox --target i586-unknown-redox --target x86_64-unknown-redox

@github-actions

github-actions Bot commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)

@xtqqczze xtqqczze changed the title chore: fix compile error on redox fix: address some errors on redox Sep 16, 2026
@xtqqczze xtqqczze changed the title fix: address some errors on redox fix: address redox build issues Sep 16, 2026
@sylvestre

sylvestre commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

still draft?

@xtqqczze
xtqqczze force-pushed the redox-cast branch 3 times, most recently from e24a733 to 67904b4 Compare September 19, 2026 19:50
@xtqqczze xtqqczze mentioned this pull request Sep 19, 2026
Merged
@xtqqczze

xtqqczze commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

@sylvestre Would you be happy to merge this as-is, or do need CI in place first?

@sylvestre

sylvestre commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

happy to merge it if the CI is green

@xtqqczze
xtqqczze marked this pull request as ready for review September 19, 2026 21:09
@xtqqczze
xtqqczze force-pushed the redox-cast branch 2 times, most recently from 41abf5a to 48b7295 Compare September 20, 2026 12:14
@codspeed

codspeed Bot commented Sep 20, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 3.04%

⚡ 1 improved benchmark
✅ 376 untouched benchmarks
⏩ 54 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation du_all_wide_tree[(5000, 500)] 38.8 ms 37.6 ms +3.04%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

Comparing xtqqczze:redox-cast (41abf5a) with main (ea21b10)2

Open in CodSpeed

Footnotes

  1. 54 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (47df573) during the generation of this report, so ea21b10 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@xtqqczze

xtqqczze commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@sylvestre ready

@xtqqczze xtqqczze mentioned this pull request Sep 23, 2026
Open
xtqqczze
xtqqczze commented Sep 25, 2026
View reviewed changes
Comment thread tests/uutests/Cargo.toml Outdated
rustix = { workspace = true, features = ["process"] }

[target.'cfg(all(unix, not(any(target_os = "macos", target_os = "openbsd"))))'.dependencies]
[target.'cfg(any(target_os = "freebsd", target_os = "hurd", target_os = "linux", target_os = "android", target_os = "macos", target_os = "netbsd"))'.dependencies]

@xtqqczze xtqqczze Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ cargo +nightly check -q -p uutests --all-targets --all-features --target aarch64-apple-darwin           
warning: unused dependency `xattr`

@xtqqczze
build: work around blake3 failure on i586-unknown-redox
2ced50f 
Add a workaround for the `blake3` build failure on `i586-unknown-redox`:

```console
error: failed to run custom build command for `blake3 v1.8.7`
```
@xtqqczze
fix: address build errors on redox
fa4137b

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xtqqczze @sylvestre