Skip to content

Revert "tests: replace rlimit dependency with rustix::process" - #14739

Closed
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:GH14664
Closed

xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:GH14664

Conversation

@xtqqczze

Copy link
Copy Markdown
Contributor

Address a build issue on Redox: #14664 (comment).

This reverts commit b60091b.

@sylvestre

Copy link
Copy Markdown
Contributor

sorry but i am not going to revert anything until we have a CI running for redox

@oech3

oech3 commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

I think we don't need to revert this since we were not running test(impossible?) for Redox on the CI previously.

@sylvestre sylvestre closed this Sep 20, 2026
@xtqqczze

Copy link
Copy Markdown
Contributor Author

I think we should add a check-only job at the very least:

cargo check --all-targets --features feat_os_unix_redox --target x86_64-unknown-redox

We can set continue-on-error: true for now so that any existing errors don’t block CI, while still giving us visibility into Redox build issues.

@sylvestre

Copy link
Copy Markdown
Contributor

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants