Skip to content

feat(isMobilePhone): Added regex for Mongolia mn-MN#1993

Merged
profnandaa merged 1 commit into
validatorjs:masterfrom
rksp25:feature/add-country-tophone
Jun 30, 2022
Merged

feat(isMobilePhone): Added regex for Mongolia mn-MN#1993
profnandaa merged 1 commit into
validatorjs:masterfrom
rksp25:feature/add-country-tophone

Conversation

@rksp25

@rksp25 rksp25 commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

Added regex for Mongolia mn-MN

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov

codecov Bot commented Jun 29, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1993 (61ee147) into master (cfcf911) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1993   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       103           
  Lines         2097      2097           
  Branches       473       473           
=========================================
  Hits          2097      2097           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcf911...61ee147. Read the comment docs.

@profnandaa

Copy link
Copy Markdown
Member

Thanks for your contrib on this. This is the very first mn-Mn locale one, you could also do more others!

@profnandaa profnandaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@profnandaa profnandaa merged commit 73098eb into validatorjs:master Jun 30, 2022
@rksp25

rksp25 commented Jul 5, 2022

Copy link
Copy Markdown
Contributor Author

Hi @profnandaa i have raised one more for country BENIN: #1997

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants