fix(review): reject stale review evidence at completion - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shell and external edits could leave a required review marked as passing and allow task completion. Bind review evidence to source contents/modes, index, HEAD, configuration and requirement context, and recheck it at review, status, transition and archive boundaries. Preserve invalidations during review, including edits reverted before completion, and require fresh evidence for legacy verdicts.
Rebuild the committed plugin bundles and add regression coverage for source/ref/policy/context changes and in-flight edits. Resolve repository paths natively so Windows short-name, casing and junction aliases do not reject a valid review root; nested roots remain rejected.
Validation: the initial full local suite passed (365 passed, 4 optional/platform skips). After the Windows path correction, typecheck, plugin build and all 23 review-gate integration tests passed locally. Current-head CI also checks Ubuntu/Windows with Node 20/22 and committed bundle synchronization. No fresh live semantic review was run. Fingerprinting requires the Git repository root and fails closed for unsupported source directories such as submodules.