fix(release): approve the held CI runs of release pull requests - #29
Merged
Merged
Conversation
…ad of dispatching CI GitHub does create pull_request runs for a pull request that GITHUB_TOKEN opened, but holds them as action_required until someone approves them. Runs started through workflow_dispatch land on the same commit yet don't count for the pull request: on repokeeper#28 its status check rollup stayed null until the held run was approved. release-pr-ci now approves those runs, and ci.yml no longer needs workflow_dispatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correction to #27, found by watching it run on this repository's release PR, #28.
pull_requestruns for a PR opened withGITHUB_TOKEN, but holds them asaction_requireduntil someone approves them.workflow_dispatchrun went green on the same commit, but the PR ignored it:statusCheckRollupstayednull, andgh pr checksshowed nothing.SUCCESSand merge stateCLEAN.Changes:
release-pr-cinow looks upactions/runs?branch=<release branch>&event=pull_request&status=action_required, retrying for up to a minute because the runs appear just after the PR event, and approves each one. The job is added whenever the release module is on, since anypull_requestworkflow may be held.ci.ymldropsworkflow_dispatchagain.pr_branchoutput description say what actually happens.The standard stays 1.4.0, which hasn't been released yet (#28 is still open).
Checks: typecheck, biome, 278/278 tests,
repokeeper checkmatches, actionlint clean. After merge, release-please updates #28 withGITHUB_TOKEN. That run tests the job for real, including whetherGITHUB_TOKENwithactions: writemay approve runs.🤖 Generated with Claude Code