fix(release): set initial-version only before the first release tag - #30
Merged
Merged
Conversation
A version file release-please never bumps, such as gradle.properties without x-release-please markers, still reads 0.0.0 after v1.0.0, so repokeeper-demo-kotlin got initial-version despite its release. A release tag now rules it out. The standard moves to 1.4.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while updating the pilots to 1.4.0: repokeeper-demo-kotlin (tag v1.0.0, manifest 1.0.0) got
initial-version: 0.1.0. Itsgradle.propertiesstill readsversion=0.0.0, because release-please's generic updater needs x-release-please markers there, and that version is the seed.initial-versionis now added only when the seed is 0.0.0 and the repository has novX.Y.Ztag. Standard 1.4.1. New test cases cover a 0.0.0 version file with and without a release tag.Checks: typecheck, biome, 278/278 tests,
repokeeper check.🤖 Generated with Claude Code