enhancement: Odometer entry - #64
Merged
Merged
Conversation
varunpan
added a commit
that referenced
this pull request
Jul 2, 2026
The odometer <input> was located via getByPlaceholder('87,432') across 6
specs (21 sites). That couples the tests to placeholder text, which is not
a stable contract — PR #64 makes the placeholder dynamic (state-dependent),
which breaks every one of these locators.
Switch to the field's stable #odometer id so the tests survive placeholder
changes. Behaviour under test is unchanged; all 21 affected tests pass.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
varunpan
added a commit
that referenced
this pull request
Jul 2, 2026
…or hardening Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ate placeholder - Added `step="1"` to enforce native integer validation on the odometer field. - Prevented keyboard input of decimal points (`.` and `,`) to block typing decimals. - Updated the placeholder to dynamically fall back to the last recorded odometer reading if available.
Owner
|
Looks good. added it to release/v0.3.1 branch. I have some other fixes i want to deploy this in, before i release this release. |
4 tasks
varunpan
added a commit
that referenced
this pull request
Jul 14, 2026
The odometer <input> was located via getByPlaceholder('87,432') across 6
specs (21 sites). That couples the tests to placeholder text, which is not
a stable contract — PR #64 makes the placeholder dynamic (state-dependent),
which breaks every one of these locators.
Switch to the field's stable #odometer id so the tests survive placeholder
changes. Behaviour under test is unchanged; all 21 affected tests pass.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
varunpan
added a commit
that referenced
this pull request
Jul 14, 2026
…or hardening Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(odometer): restrict input to whole numbers and dynamically populate placeholder
step="1"to enforce native integer validation on the odometer field..and,) to block typing decimals.