Skip to content

Add timing logs to diagnose slow update apply on EDR machines (#947) - #974

Merged
caesay merged 1 commit into
developfrom
cs/947-apply-timing-logs
Jul 2, 2026
Merged

caesay merged 1 commit into
developfrom
cs/947-apply-timing-logs

Conversation

@caesay

@caesay caesay commented Jul 2, 2026

Copy link
Copy Markdown
Member

The reporter sees a ~14s unlogged gap between the running-process check and the shortcut update phase. The process scan itself completes before the 'Skipping killing self' line is printed, so the stall must be in one of the unmeasured operations that follow: the temp dir deletions or the COM context initialization. Add elapsed-time logging around each so the next field log can pinpoint the culprit.

The reporter sees a ~14s unlogged gap between the running-process check
and the shortcut update phase. The process scan itself completes before
the 'Skipping killing self' line is printed, so the stall must be in one
of the unmeasured operations that follow: the temp dir deletions or the
COM context initialization. Add elapsed-time logging around each so the
next field log can pinpoint the culprit.
@codecov

codecov Bot commented Jul 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.97%. Comparing base (7b3d615) to head (5447ebe).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/bins/src/shared/util_windows.rs 66.66% 3 Missing ⚠️
src/bins/src/commands/apply_windows_impl.rs 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #974      +/-   ##
===========================================
+ Coverage    51.93%   51.97%   +0.03%     
===========================================
  Files          125      125              
  Lines        13593    13612      +19     
  Branches       595      595              
===========================================
+ Hits          7060     7075      +15     
- Misses        6385     6389       +4     
  Partials       148      148              
Flag Coverage Δ
nodejs 2.04% <ø> (ø)
rust 51.04% <83.33%> (+0.04%) ⬆️
vpk 23.08% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@caesay
caesay merged commit 2672c6c into develop Jul 2, 2026
50 checks passed
@caesay
caesay deleted the cs/947-apply-timing-logs branch July 2, 2026 06:51
This was referenced Sep 21, 2026
This was referenced Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant