Move resolve() for tools from Context to Agent. - #302
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
msullivan
force-pushed
the
tool-resolver
branch
from
September 22, 2026 00:09
57eeda7 to
99581bf
Compare
Add a `ToolResolver` that actually owns the logic, but have everything do it via `Agent`. Leave it on `Context` for now for backward compat.
msullivan
force-pushed
the
tool-resolver
branch
from
September 22, 2026 18:06
99581bf to
adedf27
Compare
Collaborator
|
I actually don't remember why it was the other way around. |
anbuzin
approved these changes
Sep 23, 2026
Collaborator
Author
|
Probably because Agent.run used to optionally take tools as an argument |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
ToolResolverthat actually owns the logic, but have everythingdo it via
Agent.Leave it on
Contextfor now for backward compat.