Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1st1
force-pushed
the
evaluation-model-validation
branch
from
September 28, 2026 20:36
c4dab47 to
9542e9f
Compare
anbuzin
reviewed
Sep 28, 2026
| ): | ||
| raise TypeError( | ||
| "questions must specialize BaseQuestionModel " | ||
| "with a Pydantic model" |
Collaborator
There was a problem hiding this comment.
Add an example here, like class Questions(ai.ops.experimental.BaseQuestionsModel[AnswerT]) ?
anbuzin
approved these changes
Sep 28, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #307, based on its branch.
Use plain Pydantic
BaseModelfor answers.BaseQuestionModelstores__answers_type__and validates both models in__pydantic_on_complete__, rebuilding the answer model before inspecting its fields. Supports resolved forward references and answer subclasses, and reports the exact fields missing from either model. Updates examples, docs, and tests.Validation: 45 relevant tests pass, including explicit and automatic forward-reference rebuilding; Ruff format/lint, mypy, and ty pass.