Helpers update - #7686
Merged
Merged
Conversation
huv1k
requested review from
Timer,
dav-is,
ijjk,
lfades and
timneutkens
as code owners
June 27, 2019 17:15
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
lfades
approved these changes
Jun 27, 2019
lfades
left a comment
Member
There was a problem hiding this comment.
I like this usage of get/set 💯
lfades
reviewed
Jun 27, 2019
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
ijjk
approved these changes
Jun 28, 2019
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
ijjk
reviewed
Jun 28, 2019
Janpot
reviewed
Jun 28, 2019
| export type PageConfig = { | ||
| amp?: boolean | 'hybrid' | ||
| api?: { | ||
| bodyParser?: boolean |
Contributor
There was a problem hiding this comment.
The problem with having a static export is that it always has to be configure by the user. Third party libraries can't configure the handlers they produce to opt out of this body-parser. e.g. if I create a proxy library, I'd have to ask my users to always include this static export:
import someProxy from 'third-party';
export default someProxy();
// I'd have to ask users of my library to include the following or it won't work:
export const {
api: {
bodyParser: false
}
}Co-Authored-By: JJ Kasper <jj@jjsweb.site>
Contributor
Stats from current PRClick to expand stats
Click to expand serverless stats
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves
APIhelpers to lazy load data and a possibility to opt-out from body parsing.