fix: handle static eval for sequence expression (fix TS 4.4+) - #289
Merged
Conversation
styfle
commented
May 23, 2022
Member
- Fixes Output from TypeScript 4.4+ no longer traceable #288
Codecov Report
@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 80.28% 80.33% +0.05%
==========================================
Files 13 13
Lines 1486 1490 +4
Branches 555 556 +1
==========================================
+ Hits 1193 1197 +4
Misses 122 122
Partials 171 171
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
kodiakhq Bot
pushed a commit
to vercel/vercel
that referenced
this pull request
Jun 6, 2022
Fixes an issue where `.d.ts` assets were incorrectly being compiled after a fix to nft in vercel/nft#289 - [Repro Steps](https://github.com/cheapsteak/repro-vercel-cli-build-dts-error) - [Incident](https://app.kintaba.com/incident/755531679765890512) - [Slack](https://vercel.slack.com/archives/C03JNHA844R/p1654334373086879) <img src="https://user-images.githubusercontent.com/229881/172055403-d2edfe1d-3a60-459f-bf40-506fea1d1ca4.png" height=500 />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.