fix: resolve cjs deps as cjs instead of esm - #362
Merged
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
styfle
requested changes
Sep 15, 2023
styfle
reviewed
Sep 15, 2023
styfle
approved these changes
Sep 16, 2023
styfle
left a comment
Member
There was a problem hiding this comment.
Looks good if tests pass, thanks!
|
🎉 This PR is included in version 0.24.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
nftanalyzes a file that has both arequire()and an ESMexport, the first call to acorn fails because of theexport, so it treats the whole file as ESM, which is probably fine.The problem is it treats the
require()as an ESM import which is wrong. This will cause the resolve dependency entrypoint in the dependency to get the ESM export instead of the proper CJS export.If the dependency is an
import, add it toimports. If it's arequire(), add it todepsand don't worry about whateverisESM.