Skip to content

fix: do not follow absolute paths outside job base - #568

Merged
styfle merged 6 commits into
vercel:mainfrom
teemingc:main
Feb 23, 2026
Merged

fix: do not follow absolute paths outside job base#568
styfle merged 6 commits into
vercel:mainfrom
teemingc:main

Conversation

@teemingc

@teemingc teemingc commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

related to sveltejs/kit#13764 (comment)

SvelteKit stringifies environment variables during build so that it can inject static values into the build output instead of always reading the env vars dynamically. However, @vercel/nft interprets any absolute path as an asset it should add. This causes builds on Vercel's build system to balloon in function size because it traces and bundles paths such as Node, Yarn global, etc. Often, this causes the deployment to fail because the function size exceeds the limit.

This PR ensures asset paths outside the given job base are ignored to help us avoid packaging in system dependencies.

Draft for now because I'm not confident that this fix doesn't break lots of other things

Comment thread src/utils/ast-helpers.ts Outdated
@teemingc
teemingc marked this pull request as ready for review February 19, 2026 11:26
@teemingc
teemingc requested review from a team, icyJoseph, ijjk and styfle as code owners February 19, 2026 11:26

@styfle styfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks! 🎉

@styfle
styfle enabled auto-merge (squash) February 23, 2026 17:07
@styfle
styfle merged commit 0ce8e2c into vercel:main Feb 23, 2026
12 checks passed
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

teemingc added a commit to sveltejs/kit that referenced this pull request Feb 23, 2026
closes #13764
closes #15349

We landed a fix in vercel/nft#568 that should
prevent system files from being copied into the function bundle.

---

### Please don't delete this checklist! Before submitting the PR, please
make sure you do the following:
- [x] It's really useful if your PR references an issue where it is
discussed ahead of time. In many cases, features are absent for a
reason. For large changes, please create an RFC:
https://github.com/sveltejs/rfcs
- [x] This message body should clearly illustrate what problems it
solves.
- [ ] Ideally, include a test that fails without this PR but passes with
it.
No test unless we want a test app that attempts to exceed the function
bundle size

### Tests
- [ ] Run the tests with `pnpm test` and lint the project with `pnpm
lint` and `pnpm check`

### Changesets
- [x] If your PR makes a change that should be noted in one or more
packages' changelogs, generate a changeset by running `pnpm changeset`
and following the prompts. Changesets that add features should be
`minor` and those that fix bugs should be `patch`. Please prefix
changeset messages with `feat:`, `fix:`, or `chore:`.

### Edits

- [x] Please ensure that 'Allow edits from maintainers' is checked. PRs
without this option may be closed.
Copilot AI pushed a commit to Stadly/kit that referenced this pull request Mar 6, 2026
closes sveltejs#13764
closes sveltejs#15349

We landed a fix in vercel/nft#568 that should
prevent system files from being copied into the function bundle.

---

### Please don't delete this checklist! Before submitting the PR, please
make sure you do the following:
- [x] It's really useful if your PR references an issue where it is
discussed ahead of time. In many cases, features are absent for a
reason. For large changes, please create an RFC:
https://github.com/sveltejs/rfcs
- [x] This message body should clearly illustrate what problems it
solves.
- [ ] Ideally, include a test that fails without this PR but passes with
it.
No test unless we want a test app that attempts to exceed the function
bundle size

### Tests
- [ ] Run the tests with `pnpm test` and lint the project with `pnpm
lint` and `pnpm check`

### Changesets
- [x] If your PR makes a change that should be noted in one or more
packages' changelogs, generate a changeset by running `pnpm changeset`
and following the prompts. Changesets that add features should be
`minor` and those that fix bugs should be `patch`. Please prefix
changeset messages with `feat:`, `fix:`, or `chore:`.

### Edits

- [x] Please ensure that 'Allow edits from maintainers' is checked. PRs
without this option may be closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants