Repository navigation
Fix SvelteKit config loading - #2802
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 306c6b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
🧪 E2E Test Results✅ All tests passed Summary
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
|
Contributor
|
No benchmark result files found in benchmark-results |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
NathanColosimo
force-pushed
the
codex/fix-sveltekit-e2e-pins
branch
from
July 7, 2026 20:21
f5e52dd to
c0a306d
Compare
NathanColosimo
force-pushed
the
codex/fix-sveltekit-e2e-pins
branch
from
July 7, 2026 21:09
f03c03e to
f611108
Compare
NathanColosimo
force-pushed
the
codex/fix-sveltekit-e2e-pins
branch
from
July 7, 2026 21:22
f611108 to
e7366b5
Compare
VaguelySerious
approved these changes
Jul 8, 2026
Contributor
|
Backport to This is usually an infrastructure problem (e.g. the configured AI model could not be found, an AI Gateway error, or an opencode crash) rather than a merge conflict. Check the job logs linked above for details. Once the underlying issue is fixed, re-run the Backport to stable workflow manually via |
This was referenced Jul 8, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2794.
workflow/sveltekitresolves the SvelteKit routes directoryworkflow/sveltekitimport exits are caughtRoot Cause
workflow/sveltekitcalls into SvelteKit internals to find the routes directory. SvelteKit 2.62+ changedload_config()so it resolves Vite config first. Whenworkflow/sveltekitis imported fromvite.config.ts, that recursively reloadsvite.config.tsand the original top-level import never resolves.The fix prefers SvelteKit's
load_svelte_config()export when available because it reads Svelte config without resolving Vite config, and falls back toload_config()for older SvelteKit versions.Why E2E Missed This
The SvelteKit workbench was still below the SvelteKit version that introduced the recursive config-load behavior. The local-build test also only asserted that
pnpm buildexited successfully; this failure mode could exit cleanly before the import ever logged success. The new pre-build import assertion requires an explicitworkflow/sveltekit import okmarker.Verification
corepack pnpm install --frozen-lockfilecorepack pnpm buildPATH=<corepack-pnpm-shim>:$PATH APP_NAME=sveltekit ./node_modules/.bin/vitest run packages/core/e2e/local-build.test.ts