Skip to content

Anchor trace viewer shortcut helper to the timeline's left edge #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitul-s merged 3 commits into from
Jul 9, 2026
Merged

Anchor trace viewer shortcut helper to the timeline's left edge #2837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1384771
Anchor trace viewer shortcut helper to the timeline's left edge
mitul-s Jul 9, 2026
5241df8
Raise shortcut-helper container-query threshold to 480px
mitul-s Jul 9, 2026
dc71869
Update trace-viewer.tsx
mitul-s Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/trace-shortcut-helper-timeline-align.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@workflow/web-shared': patch
---

Anchor the trace viewer shortcut helper to the timeline's left edge and hide it below a container-query width instead of a viewport breakpoint.
2 changes: 1 addition & 1 deletion packages/web-shared/src/components/new-trace-viewer/components/trace-shortcut-helper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export function TraceShortcutHelper({
};

return (
<div className="group absolute bottom-3 left-1/2 z-10 hidden h-8 max-w-[calc(100%-2rem)] -translate-x-1/2 items-center gap-1 text-xs leading-none text-gray-900 md:inline-flex">
<div className="group sticky bottom-3 z-10 ml-4 mb-3 hidden h-8 w-fit items-center gap-1 text-xs leading-none text-gray-900 @min-[480px]:flex">
<span
aria-live="polite"
aria-atomic="true"
Expand Down
11 changes: 5 additions & 6 deletions packages/web-shared/src/components/new-trace-viewer/trace-viewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ function NewTraceViewerContent({
<div
ref={timelineRef}
id="trace-timeline"
className="block min-h-0 overflow-visible relative"
className="@container block min-h-0 overflow-visible relative"
onDoubleClick={resetZoom}
onMouseMove={handleTimelineMouseMove}
onMouseLeave={handleTimelineMouseLeave}
Expand All @@ -582,6 +582,10 @@ function NewTraceViewerContent({
hoverFraction={hoverFraction}
altHeld={altHeld}
/>
<TraceShortcutHelper
hasMultipleSpans={trace.spans.length > 1}
reducedMotion={reducedMotion}
/>
</div>
</SplitPane>
<div className="absolute right-3 bottom-3 z-[5] flex items-center border border-gray-alpha-400 rounded-md bg-background-100 shadow-sm overflow-hidden divide-x divide-gray-alpha-400">
Expand Down Expand Up @@ -619,11 +623,6 @@ function NewTraceViewerContent({
onNavigateToSpan={navigateToSpan}
onClose={handleClearActiveSpan}
/>

<TraceShortcutHelper
hasMultipleSpans={trace.spans.length > 1}
reducedMotion={reducedMotion}
/>
</div>
);
}
Loading