Skip to content

test(next): cover HMR rebuild convergence #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanColosimo wants to merge 12 commits into from
Open

test(next): cover HMR rebuild convergence #3471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
98095e4
test(next): cover HMR rebuild convergence
NathanColosimo Aug 11, 2026
d45b0ab
test(next): cover latest stable and canary
NathanColosimo Aug 17, 2026
44ba779
test(next): await lazy route userland
NathanColosimo Aug 17, 2026
96a32b0
test(next): narrow HMR expectations
NathanColosimo Aug 19, 2026
5c3c4d3
test(next): update canary coverage
NathanColosimo Aug 19, 2026
9318a88
test(next): tighten HMR convergence coverage
NathanColosimo Aug 26, 2026
e0fb531
test(next): require non-source rediscovery
NathanColosimo Aug 26, 2026
7519359
test(next): assert minimal HMR rebuilds
NathanColosimo Aug 26, 2026
744bfed
test(next): exercise serde HMR across a step
NathanColosimo Aug 26, 2026
b462371
ci: centralize Next canary setup
NathanColosimo Aug 28, 2026
4b8ee7c
test(next): update canary version
NathanColosimo Aug 28, 2026
da9995c
Merge commit '43bf5b3b87' into peter/wt-3471
VaguelySerious Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changeset/next-hmr-e2e.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
---

Exercise Next.js HMR convergence against stable and canary releases.
25 changes: 25 additions & 0 deletions .github/actions/setup-next-canary/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: 'Setup Next.js Canary'
description: 'Install a Next.js canary and rebuild the workspace packages.'

inputs:
app-name:
description: 'Workbench app name'
required: true
next-version:
description: 'Next.js canary version'
required: true

runs:
using: 'composite'
steps:
- shell: bash
env:
APP_NAME: ${{ inputs.app-name }}
NEXT_VERSION: ${{ inputs.next-version }}
run: |
jq --arg version "$NEXT_VERSION" '.devDependencies.next=$version' packages/next/package.json > packages/next/package.json.new
mv packages/next/package.json.new packages/next/package.json
jq --arg version "$NEXT_VERSION" '.dependencies.next=$version' "workbench/$APP_NAME/package.json" > "workbench/$APP_NAME/package.json.new"
mv "workbench/$APP_NAME/package.json.new" "workbench/$APP_NAME/package.json"
pnpm install --no-frozen-lockfile
pnpm turbo run build --filter='!./workbench/*'
45 changes: 15 additions & 30 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}

env:
NEXT_CANARY_VERSION: 16.4.0-canary.10

jobs:
ci-scope:
name: Detect CI Scope
Expand Down Expand Up @@ -1099,12 +1102,10 @@ jobs:

- name: Setup canary
if: ${{ matrix.app.canary }}
env:
APP_NAME: ${{ matrix.app.name }}
run: |
cat packages/next/package.json | jq '.dependencies.next|="16.3.1-canary.17"' > packages/next/package.json.new && mv packages/next/package.json.new packages/next/package.json
cat "workbench/$APP_NAME/package.json" | jq '.dependencies.next|="16.3.1-canary.17"' > "workbench/$APP_NAME/package.json.new" && mv "workbench/$APP_NAME/package.json.new" "workbench/$APP_NAME/package.json"
pnpm install --no-frozen-lockfile
uses: ./.github/actions/setup-next-canary
with:
app-name: ${{ matrix.app.name }}
next-version: ${{ env.NEXT_CANARY_VERSION }}

- name: Download shared package builds
if: ${{ !matrix.app.canary }}
Expand All @@ -1113,10 +1114,6 @@ jobs:
name: e2e-package-build-artifacts
path: packages

- name: Run Initial Build for Next.js canary
if: ${{ matrix.app.canary }}
run: pnpm turbo run build --filter='!./workbench/*'

- name: Prepare workbench path
id: prepare-workbench
uses: ./.github/actions/prepare-workbench-path
Expand Down Expand Up @@ -1186,12 +1183,10 @@ jobs:

- name: Setup canary
if: ${{ matrix.app.canary }}
env:
APP_NAME: ${{ matrix.app.name }}
run: |
cat packages/next/package.json | jq '.dependencies.next|="16.3.1-canary.17"' > packages/next/package.json.new && mv packages/next/package.json.new packages/next/package.json
cat "workbench/$APP_NAME/package.json" | jq '.dependencies.next|="16.3.1-canary.17"' > "workbench/$APP_NAME/package.json.new" && mv "workbench/$APP_NAME/package.json.new" "workbench/$APP_NAME/package.json"
pnpm install --no-frozen-lockfile
uses: ./.github/actions/setup-next-canary
with:
app-name: ${{ matrix.app.name }}
next-version: ${{ env.NEXT_CANARY_VERSION }}

- name: Download shared package builds
if: ${{ !matrix.app.canary }}
Expand All @@ -1200,10 +1195,6 @@ jobs:
name: e2e-package-build-artifacts
path: packages

- name: Run Initial Build for Next.js canary
if: ${{ matrix.app.canary }}
run: pnpm turbo run build --filter='!./workbench/*'

- name: Prepare workbench path
id: prepare-workbench
uses: ./.github/actions/prepare-workbench-path
Expand Down Expand Up @@ -1302,12 +1293,10 @@ jobs:

- name: Setup canary
if: ${{ matrix.app.canary }}
env:
APP_NAME: ${{ matrix.app.name }}
run: |
cat packages/next/package.json | jq '.dependencies.next|="16.3.1-canary.17"' > packages/next/package.json.new && mv packages/next/package.json.new packages/next/package.json
cat "workbench/$APP_NAME/package.json" | jq '.dependencies.next|="16.3.1-canary.17"' > "workbench/$APP_NAME/package.json.new" && mv "workbench/$APP_NAME/package.json.new" "workbench/$APP_NAME/package.json"
pnpm install --no-frozen-lockfile
uses: ./.github/actions/setup-next-canary
with:
app-name: ${{ matrix.app.name }}
next-version: ${{ env.NEXT_CANARY_VERSION }}

- name: Download shared package builds
if: ${{ !matrix.app.canary }}
Expand All @@ -1316,10 +1305,6 @@ jobs:
name: e2e-package-build-artifacts
path: packages

- name: Run Initial Build for Next.js canary
if: ${{ matrix.app.canary }}
run: pnpm turbo run build --filter='!./workbench/*'

- name: Setup PostgreSQL Database
run: ./packages/world-postgres/bin/setup.js

Expand Down
Loading
Loading