Skip to content

Prefix marker context cards with Hook received / Attribute set - #3692

Merged
mitul-s merged 5 commits into
mainfrom
c+ms/marker-utc-tooltips-8f31
Aug 20, 2026
Merged

Prefix marker context cards with Hook received / Attribute set#3692
mitul-s merged 5 commits into
mainfrom
c+ms/marker-utc-tooltips-8f31

Conversation

@mitul-s

@mitul-s mitul-s commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Description

Trace viewer hook/attribute ticks keep the existing relative-time context card. The relative-time heading is prefixed with the event kind:

  • Hook received 6 hours, 49 minutes, 22 seconds ago
  • Attribute set 6 hours, 49 minutes, 22 seconds ago

UTC and local timestamp rows are unchanged. Copy lives next to MarkerLayer; the shared timestamp card only gained an optional heading prefix.

Hook received context card on a trace viewer marker

How did you test your changes?

  • Unit tests for computeSpanMarkers kinds.
  • pnpm vitest run src/components/trace-viewer/utils.test.ts in packages/web-shared — 33 passed.
  • Manual hover on a hook marker in the trace viewer (screenshot above).

PR Checklist - Required to merge

  • 📦 pnpm changeset was run to create a changelog for this PR
  • 🔒 DCO sign-off passes (run git commit --signoff on your commits)
  • 📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete

To show artifacts inline, enable in settings.

Open in Web Open in Cursor 

Replace the relative-time context card on hook and attribute ticks with the
shared tooltip, labeled `Hook received [UTC] …` and `Attribute set [UTC] …`.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Mitul Shah <mitulxshah@gmail.com>
@changeset-bot

changeset-bot Bot commented Aug 20, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a594562

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@workflow/web-shared Patch
@workflow/web Patch
@workflow/cli Patch
@workflow/nitro Patch
workflow Patch
@workflow/world-testing Patch
@workflow/nuxt Patch
@workflow/core Patch
@workflow/builders Patch
@workflow/next Patch
@workflow/vitest Patch
@workflow/astro Patch
@workflow/nest Patch
@workflow/rollup Patch
@workflow/sveltekit Patch
@workflow/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview Aug 20, 2026 4:10pm
example-nextjs-workflow-webpack Ready Ready Preview Aug 20, 2026 4:10pm
example-workflow Ready Ready Preview Aug 20, 2026 4:10pm
workbench-astro-workflow Ready Ready Preview Aug 20, 2026 4:10pm
workbench-express-workflow Ready Ready Preview Aug 20, 2026 4:10pm
workbench-fastify-workflow Ready Ready Preview Aug 20, 2026 4:10pm
workbench-hono-workflow Ready Ready Preview Aug 20, 2026 4:10pm
workbench-nestjs-workflow Ready Ready Preview Aug 20, 2026 4:10pm
workbench-nitro-workflow Ready Ready Preview Aug 20, 2026 4:10pm
workbench-nuxt-workflow Ready Ready Preview Aug 20, 2026 4:10pm
workbench-python-workflow Ready Ready Preview Aug 20, 2026 4:10pm
workbench-sveltekit-workflow Ready Ready Preview Aug 20, 2026 4:10pm
workbench-tanstack-start-workflow Ready Ready Preview Aug 20, 2026 4:10pm
workbench-vite-workflow Ready Ready Preview Aug 20, 2026 4:10pm
workflow-docs Ready Ready Preview, v0 Aug 20, 2026 4:10pm
workflow-swc-playground Ready Ready Preview Aug 20, 2026 4:10pm
workflow-tarballs Ready Ready Preview Aug 20, 2026 4:10pm
workflow-web Ready Ready Preview Aug 20, 2026 4:10pm

Biome requires the kind filter ternary on one line, and aria-label is not
valid on the tooltip trigger span.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Sim World

Simulated world deterministic testing for races. Traces

🟠 world-sim scenario book — 1 fail of 41 total

fence=per-spec

scenario outcome events virt replay violations
smoke-no-steps completed 3 0ms ok 0
smoke-one-step completed 6 0ms ok 0
hook-at-step-started completed 12 0ms ok 0
hook-at-step-completed completed 12 0ms ok 0
hook-at-hook-created completed 12 0ms ok 0
deadline-hook-wins completed 7 1.0h ok 0
deadline-expires completed 7 1.0h ok 0
long-sleep completed 11 30.0d ok 0
hook-never-arrives stalled 3 0ms skipped 0
step-retries-twice completed 10 2.0s ok 0
parallel-steps completed 9 0ms ok 0
hook-on-execution-state completed 12 0ms ok 0
peek-hook-before-branch completed 12 0ms ok 0
peek-hook-after-branch completed 12 0ms ok 0
peek-hook-at-registration completed 12 0ms ok 0
race-hook-before-probe completed 12 0ms ok 0
race-hook-after-probe completed 12 0ms ok 0
race-duplicate-delivery completed 13 0ms ok 0
attr-hook-before-step completed 11 0ms ok 0
attr-hook-after-step completed 11 0ms ok 0
attr-from-step-body completed 13 0ms ok 0
fork-hook-after-timeout completed 14 1.0m ok 0
fork-hook-before-timeout completed 14 1.0m ok 0
count-hook-after-timeout completed 17 1.0m ok 0
count-hook-before-timeout completed 20 1.0m ok 0
stale-read-step-count-fork completed 20 1.0m ok 0
stale-read-equal-step-counts completed 14 1.0m ok 0
step-vs-step-fork completed 12 0ms ok 0
step-vs-step-fork-fenced completed 12 0ms ok 0
fence-catches-benign-direction completed 12 5ms ok 0
in-flight-before-decision completed 17 1.0m ok 0
in-flight-before-decision-counted completed 17 1.0m ok 0
in-flight-after-decision completed 19 2.0m ok 0
stale-read-step-count-fork-fenced completed 20 1.0m ok 0
fork-hook-wins completed 13 1.0m ok 0
fork-timeout-wins completed 13 1.0m ok 0
unclaimed-payload-under-fork completed 17 1.0m ok 0
claimed-payload-under-fork completed 17 1.0m ok 0
writers-independent-step-bodies completed 12 0ms ok 0
writers-scripted-tempo completed 12 0ms ok 0
cancel-mid-step cancelled 7 0ms skipped 0

Full trace: world-sim.txt

Restore the relative-time context card on hook and attribute ticks, and
prefix the relative time with "Hook received" or "Attribute set".

Signed-off-by: Cursor Agent <cursoragent@cursor.com>
@cursor cursor Bot changed the title Use UTC tooltips for hook and attribute span markers Prefix marker context cards with Hook received / Attribute set Aug 20, 2026
Leave sortedEventMarks as a plain string filter. The prefix prop does not
need a JSDoc restatement.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>
@cursor

cursor Bot commented Aug 20, 2026

Copy link
Copy Markdown

@vercel/workflow ready for review.

Hook/attribute ticks keep the existing relative-time context card. The heading is now prefixed with the event kind (Hook received … ago / Attribute set … ago); UTC and local rows are unchanged.

Hook received context card on a trace viewer marker

@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for a06afee (AI decision).

This is a UI/UX enhancement: it adds a kind field to span markers and an optional prefix prop to the shared timestamp card so trace-viewer marker tooltips read "Hook received …" / "Attribute set …". Nothing here fixes a defect, crash, or correctness problem — the existing relative-time card already worked, it was just less descriptive — so it is additive feature work that belongs on main only.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

a06afeefe6cd6489c18bbc10e77d429529112224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants