Backport #3879: fix(core): re-arm late-claimed hook deliveries - #3905
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
* fix(core): re-arm late-claimed hook deliveries * refactor(core): clarify delivery barrier lifecycle Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 9145e4a The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
Author
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (106 failed)redis (21 failed):
turso (85 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
Contributor
|
closing since this only manifested in v5 in retained VM replays, but is't an issue in v4 even if it's "technically" a bug |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of #3879 to
stable(backport job run).AI recommendation: This is a pure correctness fix (patch changeset) for the delivery-barrier machinery in
packages/core/src/private.ts, which exists verbatim onstable— including the unarmed buffered-hook barrier, the idle safety net, and the no-oparm()on an already-retired entry that lets a run suspend before a claimed hook payload reaches workflow code. The addedasync-deserialization-orderingregression exercises the defect through the ordinary hook API with no retained-VM machinery, sostableis exposed to the same lost/hung delivery even though the failure was found in a retained VM. Note thatpackages/core/src/retained-vm-loop.test.tsdoes not exist onstable(retained VM is main-only), so that test file should be dropped from the cherry-pick.Merge conflicts were resolved by AI (opencode with
anthropic/claude-opus-5). Please review the conflict resolution carefully before merging.