Skip to content

(chore) Update Next.js to 16.3.4 in the workbench apps and @workflow/next - #4026

Merged
VaguelySerious merged 2 commits into
mainfrom
update-next-js-deps
Sep 10, 2026
Merged

VaguelySerious merged 2 commits into
mainfrom
update-next-js-deps

Conversation

@pranaygp

@pranaygp pranaygp commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Bumps next from 16.2.11 to 16.3.4 — the latest published 16.3.x — in the two Next.js workbench apps that were still behind, and in @workflow/next, which has to move with them.

Package Before After
workbench/nextjs-turbopack 16.2.11 16.3.4
workbench/nextjs-webpack 16.2.11 16.3.4
packages/next (next devDependency) 16.2.11 16.3.4

workbench/swc-playground already moved to 16.3.4 in #4018, so all three Next.js workbenches now sit on the same version, and 16.2.11 is gone from the lockfile entirely.

Why @workflow/next had to move too

The first pass bumped only the apps, and every Next.js lane went red — Node.js Module Build Errors Test, both Vercel preview deployments, and the nextjs-turbopack / nextjs-webpack E2E matrix — on next build reporting Failed to type check.

withWorkflow() takes the app's NextConfig, and that type is nominally per-copy: the app's config is typed by the next in the app's dependencies, while the parameter in @workflow/next's emitted .d.ts is typed by the next in its own devDependencies. NextConfig reaches NextConfigComplete through the webpack hook's context argument, and NextConfigComplete is Required<Omit<NextConfig, …>> — so every option a Next.js minor adds becomes a required property. 16.3 added five (agentRules, instrumentationClientInject, outputHashSalt, partialPrefetching, supportsImmutableAssets), which is enough for the two NextConfigs to stop being assignable to one another:

workbench/nextjs-turbopack/next.config.ts(21,29): error TS2345: Argument of type
'NextConfig' is not assignable to parameter of type 'NextConfig | ((phase: string,
ctx: { defaultConfig: NextConfig; }) => Promise<NextConfig>)'.
  Types of property 'webpack' are incompatible.
    …
      Types of property 'config' are incompatible.
        Type 'NextConfigComplete' is missing the following properties from type
        'Required<Omit<NextConfig, "configFile" | "cacheLife">>':
        instrumentationClientInject, supportsImmutableAssets, partialPrefetching,
        agentRules, outputHashSalt

The app is the one that fails, with nothing in the app changed — so this package has to stay in lockstep with the apps that wrap their config with it. Same shape as #3071, which moved packages/next and the workbenches together.

packages/next/src/next-version.test.ts now guards that: it finds every workbench app that both depends on next and routes its config through withWorkflow(), and asserts each one pins the same next as this package's devDependency. An app that only happens to use Next.js (the SWC playground) carries none of the coupling and is left alone. Reverting the devDependency to 16.2.11 fails the test naming both apps.

Notes

  • next@16.3.4 declares the same peer dependencies as 16.2.11, so React (19.2.7), @opentelemetry/api, and friends are untouched.
  • docs stays on 16.3.3 (see .changeset/docs-next-16-3-3.md); it does not call withWorkflow(), so it is not part of this coupling.
  • Changeset: @workflow/next patch. The workbench apps are private, so they bump nothing.

Verification

  • pnpm install resolves 16.3.4 for packages/next, workbench/nextjs-turbopack, and workbench/nextjs-webpack.
  • @workflow/next builds (tsc) clean against 16.3.4.
  • Both workbench next.config.ts files type-check against the rebuilt plugin. Pointing packages/next back at 16.2.11 reproduces the TS2345 above exactly; pointing it at 16.3.4 clears it.
  • pnpm --filter @workflow/next test: 72 passed. The one failure, swc-plugin-cache.integration.test.ts, needs the compiled Rust/wasm plugin artifact, and this environment has no Rust toolchain — unrelated to this change, left to CI.
  • scripts/check-changesets.mjs and scripts/check-no-unrun-tests.mjs both pass.

🤖 Generated with Claude Code

Bump `next` from 16.2.11 to 16.3.4 in the `nextjs-turbopack` and
`nextjs-webpack` workbench apps, bringing them in line with
`swc-playground`, which moved to 16.3.4 in #4018.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 8, 2026 20:37
@pranaygp
pranaygp requested a review from a team as a code owner September 8, 2026 20:37
@vercel

vercel Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
example-nextjs-workflow-turbopack Ready Ready Preview, v0 Sep 8, 2026 9:10pm UTC
example-nextjs-workflow-webpack Ready Ready Preview, v0 Sep 8, 2026 9:10pm UTC
example-workflow Ready Ready Preview, v0 Sep 8, 2026 9:10pm UTC
workbench-astro-workflow Ready Ready Preview, v0 Sep 8, 2026 9:10pm UTC
workbench-express-workflow Ready Ready Preview, v0 Sep 8, 2026 9:10pm UTC
workbench-fastify-workflow Ready Ready Preview, v0 Sep 8, 2026 9:10pm UTC
workbench-hono-workflow Ready Ready Preview, v0 Sep 8, 2026 9:10pm UTC
workbench-nestjs-workflow Ready Ready Preview, v0 Sep 8, 2026 9:10pm UTC
workbench-nitro-workflow Ready Ready Preview, v0 Sep 8, 2026 9:10pm UTC
workbench-nuxt-workflow Ready Ready Preview, v0 Sep 8, 2026 9:10pm UTC
workbench-python-workflow Ready Ready Preview, v0 Sep 8, 2026 9:10pm UTC
workbench-sveltekit-workflow Ready Ready Preview, v0 Sep 8, 2026 9:10pm UTC
workbench-tanstack-start-workflow Ready Ready Preview, v0 Sep 8, 2026 9:10pm UTC
workbench-vite-workflow Ready Ready Preview, v0 Sep 8, 2026 9:10pm UTC
workflow-docs Ready Ready Preview, v0 Sep 8, 2026 9:10pm UTC
workflow-swc-playground Ready Ready Preview, v0 Sep 8, 2026 9:10pm UTC
workflow-tarballs Ready Ready Preview, v0 Sep 8, 2026 9:10pm UTC
workflow-web Ready Ready Preview, v0 Sep 8, 2026 9:10pm UTC

@changeset-bot

changeset-bot Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bbbdf10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@workflow/next Patch
workflow Patch
@workflow/world-testing Patch
@workflow/core Patch
@workflow/builders Patch
@workflow/cli Patch
@workflow/nitro Patch
@workflow/vitest Patch
@workflow/web-shared Patch
@workflow/web Patch
@workflow/astro Patch
@workflow/nest Patch
@workflow/rollup Patch
@workflow/sveltekit Patch
@workflow/vite Patch
@workflow/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit bbbdf10 · Tue, 08 Sep 2026 21:31:58 GMT · run logs

Backend: vercel · app: nextjs-turbopack

Metric Scenario Best (ms) P75 (ms) P90 (ms) P99 (ms) Samples
TTFS step 1375 (+48%) 🔻 1527 🔴 (+51%) 🔻 1571 🔴 (+49%) 🔻 1634 🔴 (+15%) 30
TTFS stream 184 (-31%) 💚 1527 🔴 (+39%) 🔻 1562 🔴 (+39%) 🔻 1608 🔴 (+39%) 🔻 30
TTFS hook + stream 1256 (+22%) 🔻 1576 🔴 (+5.5%) 1602 🔴 (+3.6%) 1647 🔴 (-70%) 💚 30
Fan-out TTFS Promise.all(100 steps) 549 (+8.7%) 2216 (+180%) 🔻 2308 (+173%) 🔻 2330 (+37%) 🔻 10
Fan-out TTLS Promise.all(100 steps) 2079 (+14%) 4307 (+65%) 🔻 4348 (+39%) 🔻 8424 (+4.2%) 10
STSO 1020 steps (inline) 102 (-24%) 💚 146 (-8.8%) 164 (-7.3%) 779 (+226%) 🔻 1019
WO 1020 steps 157236 (-1.4%) 157236 (-1.4%) 157236 (-1.4%) 157236 (-1.4%) 1
CRTT first chunk (pooled) 62 (-13%) 101 (-31%) 💚 142 (-23%) 💚 191 (-12%) 28

Streams

Scenario CRTT 1st p75 p90 p99 CDV max iters
paced control (100/s, 60B) 88.5 (-30%) 146 (-40%) 229 (-37%) 467 (-32%) 128 (-36%) 10
size sweep (100/s, 160B-12KB) 86 (-24%) 152 (-37%) 200 (-45%) 517 (-2%) 116 (-50%) 10
replay gateway-gpt-5.4-nano-2000t (1x) 91 (-22%) 124 (-44%) 149 (-52%) 265 (-73%) 146 (-41%) 3
replay eve-gpt-5.6-sol-2000t (1x) 69.5 (-48%) 126 (-36%) 171 (-33%) 383 (-23%) 369 (-39%) 2
replay eve-gpt-5.6-sol-2000t (2x) 71 (-31%) 184 (-48%) 241 (-65%) 356 (-70%) 150 (-78%) 3
📈 STSO distribution vs main (inline / queue-hop histograms)

1020 steps (inline)

Cumulative STSO time: main 159325ms → this run 155747ms (Δ -3578ms, -2%)

  100-150 ms  ███████████████░░░░░░░░┃  main 519  this 809  +290
  150-200 ms  ████┃█████████            main 473  this 162  -311
  200-250 ms  ┃                         main  17  this  15    -2
  250-300 ms  ┃                         main   4  this   3    -1
  300-350 ms  ┃                         main   1  this   1    +0
  350-400 ms  ┃                         main   3  this   1    -2
  400-450 ms  ┃                         main   1  this   3    +2
  450-500 ms  ┃                         main   1  this   6    +5
  500-550 ms  ┃                         main   0  this   2    +2
  550-600 ms  ┃                         main   0  this   1    +1
  600-650 ms  ┃                         main   0  this   1    +1
  700-750 ms  ┃                         main   0  this   2    +2
  750-800 ms  ┃                         main   0  this   4    +4
  800-850 ms  ┃                         main   0  this   3    +3
  850-900 ms  ┃                         main   0  this   3    +3
  900-950 ms  ┃                         main   0  this   2    +2
1050-1100 ms  ┃                         main   0  this   1    +1
📈 CRTT drill-down vs main (RTT distributions & profiles)
variant  RTT 1ms→5s+             avg         p50         p90         p99     n
control  ······▄█▁····  124.3 (-33%)  115 (-32%)  229 (-37%)  467 (-32%)  3000
sweep    ······▄█▁▁···  124.7 (-33%)  112 (-33%)  200 (-45%)   517 (-2%)  3000
gw 1x    ·····▁▇█▁····  108.4 (-40%)  103 (-35%)  149 (-52%)  265 (-73%)  5295
eve 1x   ·····▁██▁····  109.2 (-36%)   97 (-35%)  171 (-33%)  383 (-23%)  5186
eve 2x   ·····▁▃█▂····  138.4 (-46%)  125 (-37%)  241 (-65%)  356 (-70%)  7779

RTT over stream progress (avg per tenth of stream, bars scaled min→max):

control  █▅▂▇▆▅▆▁▃▃  104–145ms
sweep    █▁▂▂▃▂▃█▇▂  115–140ms
gw 1x    ▆▁▃█▄▆▆▁▁▆  100–119ms
eve 1x   ▃▃▇▃▅▆██▂▁  94–124ms
eve 2x   ▄▂▂▃▁▃▄█▄▄  108–198ms

RTT by chunk size (avg per log size bin, ~160B → ~12KB serialized, bars scaled min→max):

sweep  ▆█▆▃▁▂▇  122–127ms

Delivery jitter over stream progress (avg positive CDV per tenth of stream, bars scaled min→max):

control  ▇▆▆▆▅▇█▁▅█  30–42ms
sweep    ▅▄██▇▇▇▇▅▁  41–55ms
gw 1x    █▃▄▃▄▆▇▂▁▄  29–35ms
eve 1x   ▂▃▃▁█▃▅▂▁▂  20–28ms
eve 2x   █▂▁▃▂▂▅▂▂▇  20–27ms
ℹ️ Metric definitions & methodology

Streams: first-chunk RTT (the stream-open path, before any buffering/backpressure), CRTT percentiles, and worst delivery stall (CDV max). Cells are medians across iterations; per-run values in the artifacts. No 🔴/🟢 marks until targets attach.

The collapsed STSO distribution section above buckets every step gap, split inline (same warm process — pure framework overhead) vs queue-hop (fresh process — dispatch, reinit, replay). █ = main, ┃ = this run, ░ = fill.

The collapsed CRTT drill-down: per-variant RTT histograms (fixed log bins, · = empty) and mean RTT/positive-CDV profile lines over stream progress and chunk size. Histograms, avgs, and profiles merge exactly across runs; p50–p99 are percentile-of-percentiles. Per-index rows live in the artifacts.

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body) · Fan-out TTFS: fan-out time to first step (in-deployment start() → first of the parallel step bodies to complete) · Fan-out TTLS: fan-out time to last step (in-deployment start() → last of the parallel step bodies to complete, i.e. when the Promise.all resolves) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · CRTT: chunk round-trip time (per-chunk write → read latency, one clock domain: deployment → stream backend → same deployment) · CDV: chunk delay variation / delivery jitter (inter-arrival gap minus inter-write gap per seq-adjacent pair; skew-free; the row is each run's MAX positive value, so one stall moves it)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · Promise.all(100 steps): 100 trivial no-op steps started together in a single Promise.all; Fan-out TTFS is the first of them to complete and Fan-out TTLS the last, both from the in-deployment clientStart, so their gap is the spread the runtime adds across the fan-out · paced control (100/s, 60B): the control: 300 tiny (~60B) deltas metronome-paced at 100/s — zero workload structure, so it reads the transport floor and flush cadence, and disambiguates transport-wide vs workload-specific when a replay row moves · size sweep (100/s, 160B-12KB): same pacing as the control with deltas padded in rotation across seven log-spaced sizes (~160B–12KB) — rotation decouples size from stream position, so it isolates whether chunk size causes latency · replay gateway-gpt-5.4-nano-2000t (1x): raw provider SSE cadence captured at the AI gateway boundary (gpt-5.4-nano, the most popular gateway model; per-token deltas p50 208B = the modal production chunk size), replayed exactly as measured — the typical customer's workload; its CDV is the typical customer's real delivery jitter · replay eve-gpt-5.6-sol-2000t (1x): a captured eve turn (gpt-5.6-sol, the most-used demanding eve model; ~2000 output tokens = production p50 turn length) replayed exactly as measured — eve's envelope protocol re-ships the cumulative message so sizes ramp 142B→13KB; the demanding outlier tenant's reality · replay eve-gpt-5.6-sol-2000t (2x): the same eve capture at 2x — the headroom/stress row; real fast-tier models emit the same chunk sizes at proportionally higher rate, so time compression is a faithful speed model · first chunk (pooled): every run's seq-0 RTT pooled across all stream scenarios — the first chunk precedes any workload differentiation, so pooling samples one shared stream-open path with exact percentiles

Replay cadences (semantic sha256) — eve-gpt-5.6-sol-2000t eaf22f5946e7c61f3c65c7006d550df180cfabd4e706254a09f22aec0cfb420d · gateway-gpt-5.4-nano-2000t 6f24ac518b6b83ff1d0e85a5fe78230db192716d66a7fc6b2fe022752001d041

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600

All timestamps are deployment-side; runs are triggered in-deployment, so the CI runner and api.vercel.com sit outside every measured window. TTFS = start() → first step body (includes dispatch + any cold start); Fan-out TTFS/TTLS = first/last step completion of one Promise.all from the same anchor (the gap is the runtime’s fan-out spread); STSO/WO between step bodies; CRTT inside the workflow (excludes the api.vercel.com read path).

Cold starts stay in the numbers (real bursty-workload latency, inflates P75+); Best is the warm floor.

@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

✅ All tests passed

⚠️ Flaky E2E Tests (passed on retry)

These tests failed at least once and passed on a retry. A recurring entry here is a real race worth investigating.

14 flaky tests
  • addTenWorkflow (sveltekit)
  • Calculator.calculate - static workflow method using static step methods from another class (sveltekit)
  • cancelRun via CLI - cancelling a running workflow (express)
  • cancelRun via CLI - cancelling a running workflow (hono)
  • cancelRun via CLI - cancelling a running workflow (nextjs-turbopack)
  • cancelRun via CLI - cancelling a running workflow (nextjs-webpack)
  • fire-and-forget: void setAttributes lands without awaiting (example)
  • hookCleanupTestWorkflow - hook token reuse after workflow completion (tanstack-start)
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep (nextjs-webpack)
  • maxRetries=0 disables retries (python)
  • Promise.all of disjoint-key writes: every key lands (tanstack-start)
  • setAttributesWorkflow: workflow-body calls append native attr_set events and merge correctly (python)
  • start: reserved-prefix initial attributes are seeded with allowReservedAttributes (nextjs-turbopack)
  • step throw of a non-Error value preserves it as cause on the wrapping FatalError (nest)

🛠 Infra Events (absorbed by the harness)

Platform anomalies the e2e harness detected and worked around (e.g. a run the queue never picked up, replaced by a fresh run). Clustered timestamps indicate a backend blip; a steady drip indicates a platform issue worth escalating.

  • cold-start-warmup · suite warmup (tanstack-start) · at 21:15:03Z · abandoned wrun_01M21DYVBASQCT3RE0M05WBDZ9

E2E Test Summary

Summary
Passed Failed Skipped Total
✅ ▲ Vercel Production 3662 0 685 4347
✅ 💻 Local Development 3922 0 586 4508
✅ 📦 Local Production 3922 0 586 4508
✅ 🐘 Local Postgres 3922 0 586 4508
✅ 🪟 Windows 320 0 2 322
✅ 🌐 Cross-language Conformance 68 0 74 142
✅ vercel-http-transport 823 0 143 966
✅ vercel-multi-region 27 0 0 27
✅ vercel-ws-transport 557 0 87 644
Total 17223 0 2749 19972
Details by Category

✅ ▲ Vercel Production

App Passed Failed Skipped
✅ astro-node 133 0 28
✅ astro-quickjs 133 0 28
✅ example-node 133 0 28
✅ example-quickjs 133 0 28
✅ express-node 133 0 28
✅ express-quickjs 133 0 28
✅ fastify-node 133 0 28
✅ fastify-quickjs 133 0 28
✅ hono-node 133 0 28
✅ hono-quickjs 133 0 28
✅ nest-node 133 0 28
✅ nest-quickjs 133 0 28
✅ nextjs-turbopack-node 158 0 3
✅ nextjs-turbopack-quickjs 158 0 3
✅ nextjs-webpack-node 158 0 3
✅ nextjs-webpack-quickjs 158 0 3
✅ nitro-node 133 0 28
✅ nitro-quickjs 133 0 28
✅ nuxt-node 133 0 28
✅ nuxt-quickjs 133 0 28
✅ python-node 66 0 95
✅ sveltekit-node 152 0 9
✅ sveltekit-quickjs 152 0 9
✅ tanstack-start-node 133 0 28
✅ tanstack-start-quickjs 133 0 28
✅ vite-node 133 0 28
✅ vite-quickjs 133 0 28

✅ 💻 Local Development

App Passed Failed Skipped
✅ astro-stable-node 134 0 27
✅ astro-stable-quickjs 134 0 27
✅ express-stable-node 134 0 27
✅ express-stable-quickjs 134 0 27
✅ fastify-stable-node 134 0 27
✅ fastify-stable-quickjs 134 0 27
✅ hono-stable-node 134 0 27
✅ hono-stable-quickjs 134 0 27
✅ nest-stable-node 134 0 27
✅ nest-stable-quickjs 134 0 27
✅ nextjs-turbopack-canary-node 141 0 20
✅ nextjs-turbopack-canary-quickjs 141 0 20
✅ nextjs-turbopack-stable-node 160 0 1
✅ nextjs-turbopack-stable-quickjs 160 0 1
✅ nextjs-webpack-canary-node 141 0 20
✅ nextjs-webpack-canary-quickjs 141 0 20
✅ nextjs-webpack-stable-node 160 0 1
✅ nextjs-webpack-stable-quickjs 160 0 1
✅ nitro-stable-node 134 0 27
✅ nitro-stable-quickjs 134 0 27
✅ nuxt-stable-node 134 0 27
✅ nuxt-stable-quickjs 134 0 27
✅ sveltekit-stable-node 153 0 8
✅ sveltekit-stable-quickjs 153 0 8
✅ tanstack-start-node 134 0 27
✅ tanstack-start-quickjs 134 0 27
✅ vite-stable-node 134 0 27
✅ vite-stable-quickjs 134 0 27

✅ 📦 Local Production

App Passed Failed Skipped
✅ astro-stable-node 134 0 27
✅ astro-stable-quickjs 134 0 27
✅ express-stable-node 134 0 27
✅ express-stable-quickjs 134 0 27
✅ fastify-stable-node 134 0 27
✅ fastify-stable-quickjs 134 0 27
✅ hono-stable-node 134 0 27
✅ hono-stable-quickjs 134 0 27
✅ nest-stable-node 134 0 27
✅ nest-stable-quickjs 134 0 27
✅ nextjs-turbopack-canary-node 141 0 20
✅ nextjs-turbopack-canary-quickjs 141 0 20
✅ nextjs-turbopack-stable-node 160 0 1
✅ nextjs-turbopack-stable-quickjs 160 0 1
✅ nextjs-webpack-canary-node 141 0 20
✅ nextjs-webpack-canary-quickjs 141 0 20
✅ nextjs-webpack-stable-node 160 0 1
✅ nextjs-webpack-stable-quickjs 160 0 1
✅ nitro-stable-node 134 0 27
✅ nitro-stable-quickjs 134 0 27
✅ nuxt-stable-node 134 0 27
✅ nuxt-stable-quickjs 134 0 27
✅ sveltekit-stable-node 153 0 8
✅ sveltekit-stable-quickjs 153 0 8
✅ tanstack-start-node 134 0 27
✅ tanstack-start-quickjs 134 0 27
✅ vite-stable-node 134 0 27
✅ vite-stable-quickjs 134 0 27

✅ 🐘 Local Postgres

App Passed Failed Skipped
✅ astro-stable-node 134 0 27
✅ astro-stable-quickjs 134 0 27
✅ express-stable-node 134 0 27
✅ express-stable-quickjs 134 0 27
✅ fastify-stable-node 134 0 27
✅ fastify-stable-quickjs 134 0 27
✅ hono-stable-node 134 0 27
✅ hono-stable-quickjs 134 0 27
✅ nest-stable-node 134 0 27
✅ nest-stable-quickjs 134 0 27
✅ nextjs-turbopack-canary-node 141 0 20
✅ nextjs-turbopack-canary-quickjs 141 0 20
✅ nextjs-turbopack-stable-node 160 0 1
✅ nextjs-turbopack-stable-quickjs 160 0 1
✅ nextjs-webpack-canary-node 141 0 20
✅ nextjs-webpack-canary-quickjs 141 0 20
✅ nextjs-webpack-stable-node 160 0 1
✅ nextjs-webpack-stable-quickjs 160 0 1
✅ nitro-stable-node 134 0 27
✅ nitro-stable-quickjs 134 0 27
✅ nuxt-stable-node 134 0 27
✅ nuxt-stable-quickjs 134 0 27
✅ sveltekit-stable-node 153 0 8
✅ sveltekit-stable-quickjs 153 0 8
✅ tanstack-start-node 134 0 27
✅ tanstack-start-quickjs 134 0 27
✅ vite-stable-node 134 0 27
✅ vite-stable-quickjs 134 0 27

✅ 🪟 Windows

App Passed Failed Skipped
✅ nextjs-turbopack-node 160 0 1
✅ nextjs-turbopack-quickjs 160 0 1

✅ 🌐 Cross-language Conformance

App Passed Failed Skipped
✅ python 68 0 74

✅ vercel-http-transport

App Passed Failed Skipped
✅ example 133 0 28
✅ express 133 0 28
✅ hono 133 0 28
✅ nextjs-turbopack 158 0 3
✅ nitro 133 0 28
✅ vite 133 0 28

✅ vercel-multi-region

App Passed Failed Skipped
✅ nextjs-turbopack 27 0 0

✅ vercel-ws-transport

App Passed Failed Skipped
✅ example 133 0 28
✅ express 133 0 28
✅ nextjs-turbopack 158 0 3
✅ vite 133 0 28

📋 View full workflow run

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Dependency bumps plus a large lockfile re-resolution can have repo-wide build/test impact that should be validated via CI before approval.

Pull request overview

This PR aligns the two remaining Next.js-based workbench apps (nextjs-turbopack and nextjs-webpack) to next@16.3.4, matching workbench/swc-playground so all Next.js workbenches are on the same version.

Changes:

  • Bump next from 16.2.11 → 16.3.4 in workbench/nextjs-turbopack and workbench/nextjs-webpack.
  • Update pnpm-lock.yaml to reflect the new next resolution and resulting dependency graph changes.
File summaries
File Description
workbench/nextjs-webpack/package.json Pins next to 16.3.4 for the webpack-based Next.js workbench.
workbench/nextjs-turbopack/package.json Pins next to 16.3.4 for the turbopack-based Next.js workbench.
pnpm-lock.yaml Lockfile update reflecting next@16.3.4 and associated re-resolution.
Review details

Files not reviewed (1)

  • pnpm-lock.yaml: Generated file
  • Files reviewed: 2/3 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Sim World

Simulated world deterministic testing for races. Traces

🟠 world-sim scenario book — 1 fail of 41 total

fence=per-spec

scenario outcome events virt replay violations
✅ smoke-no-steps completed 3 0ms ok 0
✅ smoke-one-step completed 6 0ms ok 0
✅ hook-at-step-started completed 12 0ms ok 0
✅ hook-at-step-completed completed 12 0ms ok 0
✅ hook-at-hook-created completed 12 0ms ok 0
✅ deadline-hook-wins completed 7 1.0h ok 0
✅ deadline-expires completed 7 1.0h ok 0
✅ long-sleep completed 11 30.0d ok 0
✅ hook-never-arrives stalled 3 0ms skipped 0
✅ step-retries-twice completed 10 2.0s ok 0
✅ parallel-steps completed 9 0ms ok 0
✅ hook-on-execution-state completed 12 0ms ok 0
✅ peek-hook-before-branch completed 12 0ms ok 0
✅ peek-hook-after-branch completed 12 0ms ok 0
✅ peek-hook-at-registration completed 12 0ms ok 0
✅ race-hook-before-probe completed 12 0ms ok 0
✅ race-hook-after-probe completed 12 0ms ok 0
✅ race-duplicate-delivery completed 13 0ms ok 0
✅ attr-hook-before-step completed 11 0ms ok 0
✅ attr-hook-after-step completed 11 0ms ok 0
✅ attr-from-step-body completed 13 0ms ok 0
✅ fork-hook-after-timeout completed 14 1.0m ok 0
✅ fork-hook-before-timeout completed 14 1.0m ok 0
✅ count-hook-after-timeout completed 17 1.0m ok 0
✅ count-hook-before-timeout completed 20 1.0m ok 0
✅ stale-read-step-count-fork completed 20 1.0m ok 0
✅ stale-read-equal-step-counts completed 14 1.0m ok 0
✅ step-vs-step-fork completed 12 0ms ok 0
✅ step-vs-step-fork-fenced completed 12 0ms ok 0
✅ fence-catches-benign-direction completed 12 5ms ok 0
✅ in-flight-before-decision completed 17 1.0m ok 0
❌ in-flight-before-decision-counted completed 17 1.0m ok 0
✅ in-flight-after-decision completed 19 2.0m ok 0
✅ stale-read-step-count-fork-fenced completed 20 1.0m ok 0
✅ fork-hook-wins completed 13 1.0m ok 0
✅ fork-timeout-wins completed 13 1.0m ok 0
✅ unclaimed-payload-under-fork completed 17 1.0m ok 0
✅ claimed-payload-under-fork completed 17 1.0m ok 0
✅ writers-independent-step-bodies completed 12 0ms ok 0
✅ writers-scripted-tempo completed 12 0ms ok 0
✅ cancel-mid-step cancelled 7 0ms skipped 0

Full trace: world-sim.txt

@vercel vercel Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

packages/next pins next@16.2.11 while workbench apps were bumped to next@16.3.4, causing withWorkflow's parameter to expect a 16.2.11 NextConfig that is incompatible with the app's 16.3.4 NextConfig (TS2345 during next build).

Fix on Vercel

@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor
Framework Flow route Step reg. Framework output
hono 201.6 KiB (±0) 41.1 KiB (±0) 1.78 MiB (-108 B)
nextjs-turbopack 207.0 KiB (±0) 439 B (±0) 773.1 KiB (+3.0 KiB)
About these numbers

Sizes are gzip; parentheses show the change against main.
Flow route and Step reg. gate this job, on raw bytes rather than the gzip shown, at max(2%, 50.0 KiB). Framework output is informational.

bbbdf10 · run

`withWorkflow()` takes the app's `NextConfig`, and that type is nominally
per-copy: the app's config is typed by the `next` in the app's
dependencies, while the parameter in `@workflow/next`'s emitted `.d.ts`
comes from the `next` in its own devDependencies. `NextConfig` reaches
`NextConfigComplete` through the `webpack` hook's context argument, and
`NextConfigComplete` is `Required<Omit<NextConfig, …>>`, so every option
a minor adds becomes a required property. 16.3 added five of them
(`agentRules`, `instrumentationClientInject`, `outputHashSalt`,
`partialPrefetching`, `supportsImmutableAssets`), which is enough for the
two `NextConfig`s to stop being assignable to one another.

Moving the workbench apps to 16.3.4 while this package stayed on 16.2.11
therefore failed each app's own build:

    workbench/nextjs-turbopack/next.config.ts(21,29): error TS2345:
    Argument of type 'NextConfig' is not assignable to parameter of type
    'NextConfig | ((phase: string, ctx: { defaultConfig: NextConfig; })
    => Promise<NextConfig>)'.

Bump the devDependency to 16.3.4 so the published types are generated
against the same release the apps build with, and add a test that fails
when this package and any workbench app that wraps its config with
`withWorkflow()` drift apart again.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Co-Authored-By: Pranay Prakash <1797812+pranaygp@users.noreply.github.com>
@VaguelySerious
VaguelySerious merged commit 0b1216e into main Sep 10, 2026
185 of 186 checks passed
@VaguelySerious
VaguelySerious deleted the update-next-js-deps branch September 10, 2026 21:06
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 0b1216e (AI decision).

This is a routine dependency bump: next 16.2.11 → 16.3.4 in two private workbench apps and in @workflow/next's devDependency (plus a new test pinning them together), with no vulnerability or user-facing defect motivating it. The type-check failure it fixes was self-inflicted by the bump itself, not a problem that exists on stable, so it does not qualify as a stability fix for the maintenance line.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

0b1216ebe21265a028da1015991952e676a168ce

pranaygp added a commit that referenced this pull request Sep 10, 2026
…ry-2

* origin/main:
  [core] Log pending consumers in divergence diagnostics (#4021)
  fix(web-shared): stop event payload stub flash in events view (#3951)
  fix: order the 429 check before the 4xx check in the workflow skill (#3915)
  test(swc-plugin): verify class-name preservation at runtime (#4015)
  (chore) Update Next.js to 16.3.4 in the workbench apps and @workflow/next (#4026)
pranaygp added a commit that referenced this pull request Sep 10, 2026
…ture

main bumped the workbench apps (#4026); the fixture pins the same
next/react versions so pnpm hoists a single @types/react, and the stale
16.2.11 pin left the lockfile without a resolvable entry.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

This branch was successfully deployed

18 active deployments
Preview – workflow-swc-playground — bbbdf102 Deployed Sep 8, 2026 by vercel[bot]
Preview – workflow-docs — bbbdf102 Deployed Sep 8, 2026 by vercel[bot]
Preview – example-nextjs-workflow-webpack — bbbdf102 Deployed Sep 8, 2026 by vercel[bot]
Preview – workbench-vite-workflow — bbbdf102 Deployed Sep 8, 2026 by vercel[bot]
Preview – example-nextjs-workflow-turbopack — bbbdf102 Deployed Sep 8, 2026 by vercel[bot]
Preview – workbench-nuxt-workflow — bbbdf102 Deployed Sep 8, 2026 by vercel[bot]
Preview – workbench-tanstack-start-workflow — bbbdf102 Deployed Sep 8, 2026 by vercel[bot]
Preview – workbench-sveltekit-workflow — bbbdf102 Deployed Sep 8, 2026 by vercel[bot]
Preview – workbench-nitro-workflow — bbbdf102 Deployed Sep 8, 2026 by vercel[bot]
Preview – workbench-astro-workflow — bbbdf102 Deployed Sep 8, 2026 by vercel[bot]
Preview – workflow-tarballs — bbbdf102 Deployed Sep 8, 2026 by vercel[bot]
Preview – example-workflow — bbbdf102 Deployed Sep 8, 2026 by vercel[bot]
Preview – workbench-express-workflow — bbbdf102 Deployed Sep 8, 2026 by vercel[bot]
Preview – workbench-fastify-workflow — bbbdf102 Deployed Sep 8, 2026 by vercel[bot]
Preview – workbench-nestjs-workflow — bbbdf102 Deployed Sep 8, 2026 by vercel[bot]
Preview – workbench-hono-workflow — bbbdf102 Deployed Sep 8, 2026 by vercel[bot]
Preview – workflow-web — bbbdf102 Deployed Sep 8, 2026 by vercel[bot]
Preview – workbench-python-workflow — bbbdf102 Deployed Sep 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants